Fix collaborators displays under custom tab on left navigation when saved object permission is disabled (#9734)

* Fix collaborators displays when saved object permission is disabled

Signed-off-by: Owen Wang <[email protected]>

* Changeset file for PR #9734 created/updated

* Address comments

Signed-off-by: Owen Wang <[email protected]>

---------

Signed-off-by: Owen Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: FriedhelmWS

changelogs/fragments/9734.yml

@@ -0,0 +1,2 @@
+fix:
+- Fix collaborators displays under custom tab on navigation when saved object permission is disabled ([#9734](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9734))

src/plugins/workspace/public/plugin.test.ts

@@ -556,6 +556,88 @@ describe('Workspace plugin', () => {
     expect(coreStart.chrome.globalSearch.unregisterSearchCommand).toBeCalledWith('pagesSearch');
   });
 
+  it('#start should update collaboratorsAppUpdater correctly if permission enabled', async () => {
+    const workspacePlugin = new WorkspacePlugin();
+    const setupMock = getSetupMock();
+    const coreStart = coreMock.createStart();
+    await workspacePlugin.setup(setupMock, {});
+
+    const appUpdaterSpy = jest.spyOn((workspacePlugin as any).collaboratorsAppUpdater$, 'next');
+
+    const startMock = {
+      ...coreStart,
+      chrome: {
+        ...coreStart.chrome,
+        navGroup: {
+          ...coreStart.chrome.navGroup,
+          getNavGroupEnabled: jest.fn().mockReturnValue(true),
+        },
+      },
+      application: {
+        ...coreStart.application,
+        capabilities: {
+          ...coreStart.application.capabilities,
+          workspaces: {
+            ...coreStart.application.capabilities.workspaces,
+            permissionEnabled: true,
+          },
+        },
+      },
+    };
+
+    workspacePlugin.start(startMock, getMockDependencies());
+
+    expect(appUpdaterSpy).toHaveBeenCalled();
+    const updaterFn = appUpdaterSpy.mock.calls[0][0];
+    const result = (updaterFn as any)();
+
+    expect(result).toStrictEqual({
+      status: AppStatus.accessible,
+      navLinkStatus: AppNavLinkStatus.visible,
+    });
+  });
+
+  it('#start should update collaboratorsAppUpdater correctly if permission disabled', async () => {
+    const workspacePlugin = new WorkspacePlugin();
+    const setupMock = getSetupMock();
+    const coreStart = coreMock.createStart();
+    await workspacePlugin.setup(setupMock, {});
+
+    const appUpdaterSpy = jest.spyOn((workspacePlugin as any).collaboratorsAppUpdater$, 'next');
+
+    const startMock = {
+      ...coreStart,
+      chrome: {
+        ...coreStart.chrome,
+        navGroup: {
+          ...coreStart.chrome.navGroup,
+          getNavGroupEnabled: jest.fn().mockReturnValue(false),
+        },
+      },
+      application: {
+        ...coreStart.application,
+        capabilities: {
+          ...coreStart.application.capabilities,
+          workspaces: {
+            ...coreStart.application.capabilities.workspaces,
+            permissionEnabled: false,
+          },
+        },
+      },
+    };
+
+    workspacePlugin.start(startMock, getMockDependencies());
+
+    expect(appUpdaterSpy).toHaveBeenCalled();
+    const updaterFn = appUpdaterSpy.mock.calls[0][0];
+    const result = (updaterFn as any)();
+
+    expect(result).toStrictEqual({
+      status: AppStatus.inaccessible,
+      navLinkStatus: AppNavLinkStatus.hidden,
+    });
+  });
+
   it('#stop should call unregisterNavGroupUpdater', async () => {
     const workspacePlugin = new WorkspacePlugin();
     const setupMock = getSetupMock();

src/plugins/workspace/public/plugin.ts

@@ -570,9 +570,10 @@ export class WorkspacePlugin
     this.collaboratorsAppUpdater$.next(() => {
       return {
         status: isPermissionEnabled ? AppStatus.accessible : AppStatus.inaccessible,
-        navLinkStatus: core.chrome.navGroup.getNavGroupEnabled()
-          ? AppNavLinkStatus.visible
-          : AppNavLinkStatus.hidden,
+        navLinkStatus:
+          core.chrome.navGroup.getNavGroupEnabled() && isPermissionEnabled
+            ? AppNavLinkStatus.visible
+            : AppNavLinkStatus.hidden,
       };
     });