[Explore] do not detect and auto select tab when switching dataset (#10807)

There is an issue when loading a saved explore, the active tab is set to Logs even when the saved explore has Visualization as active tab.

When loading a saved explore, the active tab should already been set by src/plugins/explore/public/application/utils/hooks/use_page_initialization.ts, the current DatasetChangeMiddleware also get triggered after loading a saved explore, but it should NOT detectAndSetOptimalTab any more in this case.

And for regular data set change, we don't need this detectAndSetOptimalTab as well, because data set change always reset the query to emtpy and the select tab should be Logs in this case.

This commit removed detectAndSetOptimalTab from DatasetChangeMiddleware

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: ruanyl

changelogs/fragments/10807.yml

@@ -0,0 +1,2 @@
+fix:
+- Fix active tab not set when loading saved explore if no vis rule matched ([#10807](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10807))

src/plugins/explore/public/application/utils/state_management/middleware/dataset_change_middleware.test.ts

@@ -21,7 +21,6 @@ import { DEFAULT_DATA } from '../../../../../../data/common';
 import { getPromptModeIsAvailable } from '../../get_prompt_mode_is_available';
 import { getSummaryAgentIsAvailable } from '../../get_summary_agent_is_available';
 import * as queryActions from '../actions/query_actions';
-import * as tabActions from '../actions/detect_optimal_tab';
 import * as resetLegacyStateActions from '../actions/reset_legacy_state';
 
 jest.mock('../../get_prompt_mode_is_available', () => ({
@@ -47,9 +46,6 @@ jest.mock('../actions/reset_legacy_state', () => ({
 const mockedExecuteQueries = queryActions.executeQueries as jest.MockedFunction<
   typeof queryActions.executeQueries
 >;
-const mockedDetectAndSetOptimalTab = tabActions.detectAndSetOptimalTab as jest.MockedFunction<
-  typeof tabActions.detectAndSetOptimalTab
->;
 const mockedGetPromptModeIsAvailable = getPromptModeIsAvailable as jest.MockedFunction<
   typeof getPromptModeIsAvailable
 >;
@@ -126,10 +122,6 @@ describe('createDatasetChangeMiddleware', () => {
     // Verify the executeQueries action was dispatched
     expect(mockedExecuteQueries).toHaveBeenCalledWith({ services: mockServices });
     expect(mockStore.dispatch).toHaveBeenCalledWith({ type: 'mock/executeQueries' });
-
-    // Verify the detectAndSetOptimalTab action was dispatched
-    expect(mockedDetectAndSetOptimalTab).toHaveBeenCalledWith({ services: mockServices });
-    expect(mockStore.dispatch).toHaveBeenCalledWith({ type: 'mock/detectOptimalTab' });
   });
 
   it('should trigger side effects when dataset changes with setQueryWithHistory', async () => {
@@ -221,7 +213,6 @@ describe('createDatasetChangeMiddleware', () => {
 
     // Verify that execute queries was not called
     expect(mockedExecuteQueries).not.toHaveBeenCalled();
-    expect(mockedDetectAndSetOptimalTab).not.toHaveBeenCalled();
   });
 
   it('should update prompt mode availability only if different from current state', async () => {

src/plugins/explore/public/application/utils/state_management/middleware/dataset_change_middleware.ts

@@ -95,7 +95,6 @@ export const createDatasetChangeMiddleware = (
           }
 
           await store.dispatch(executeQueries({ services }) as any);
-          store.dispatch(detectAndSetOptimalTab({ services }) as any);
         } catch (error) {
           services.notifications?.toasts.addError(error, {
             title: 'Error loading dataset',