[Workspace] Remove the restriction that workspace cannot be created without datasource (#10861)

* Remove the restriction that workspace cannot be created without datasource

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #10861 created/updated

* Changeset file for PR #10861 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: yubonluo

changelogs/fragments/10861.yml

@@ -0,0 +1,2 @@
+feat:
+- [Workspace] Remove the restriction that workspace cannot be created without datasource ([#10861](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10861))

src/plugins/workspace/public/components/workspace_creator/workspace_create_action_panel.test.tsx

@@ -40,7 +40,6 @@ describe('WorkspaceCreateActionPanel', () => {
         }}
         application={mockApplication}
         isSubmitting={false}
-        dataSourceEnabled
       />
     );
     const createButton = screen.getByText('Create workspace');
@@ -58,55 +57,19 @@ describe('WorkspaceCreateActionPanel', () => {
         }}
         application={mockApplication}
         isSubmitting={false}
-        dataSourceEnabled
       />
     );
     const createButton = screen.getByText('Create workspace');
     expect(createButton.closest('button')).toBeDisabled();
   });
 
-  it('should disable the "Create Workspace" button when data source enabled and no data sources selected', () => {
-    render(
-      <WorkspaceCreateActionPanel
-        formId={formId}
-        formData={{
-          ...formData,
-          selectedDataSourceConnections: [],
-        }}
-        application={mockApplication}
-        isSubmitting={false}
-        dataSourceEnabled
-      />
-    );
-    const createButton = screen.getByText('Create workspace');
-    expect(createButton.closest('button')).toBeDisabled();
-  });
-
-  it('should enable the "Create Workspace" button when no data sources selected but no data source enabled', () => {
-    render(
-      <WorkspaceCreateActionPanel
-        formId={formId}
-        formData={{
-          ...formData,
-          selectedDataSourceConnections: [],
-        }}
-        application={mockApplication}
-        isSubmitting={false}
-        dataSourceEnabled={false}
-      />
-    );
-    const createButton = screen.getByText('Create workspace');
-    expect(createButton.closest('button')).not.toBeDisabled();
-  });
-
   it('should enable the "Create Workspace" button when name and description are within the maximum length', () => {
     render(
       <WorkspaceCreateActionPanel
         formId={formId}
         formData={formData}
         application={mockApplication}
         isSubmitting={false}
-        dataSourceEnabled
       />
     );
     const createButton = screen.getByText('Create workspace');
@@ -120,7 +83,6 @@ describe('WorkspaceCreateActionPanel', () => {
         formData={formData}
         application={mockApplication}
         isSubmitting
-        dataSourceEnabled
       />
     );
     expect(screen.getByText('Create workspace').closest('button')).toBeDisabled();

src/plugins/workspace/public/components/workspace_creator/workspace_create_action_panel.tsx

@@ -24,23 +24,20 @@ interface WorkspaceCreateActionPanelProps {
   formData: Pick<WorkspaceFormDataState, 'name' | 'description' | 'selectedDataSourceConnections'>;
   application: ApplicationStart;
   isSubmitting: boolean;
-  dataSourceEnabled: boolean;
 }
 
 export const WorkspaceCreateActionPanel = ({
   formId,
   formData,
   application,
   isSubmitting,
-  dataSourceEnabled,
 }: WorkspaceCreateActionPanelProps) => {
   const [isCancelModalVisible, setIsCancelModalVisible] = useState(false);
   const closeCancelModal = useCallback(() => setIsCancelModalVisible(false), []);
   const showCancelModal = useCallback(() => setIsCancelModalVisible(true), []);
   const createButtonDisabled =
     (formData.name?.length ?? 0) > MAX_WORKSPACE_NAME_LENGTH ||
-    (formData.description?.length ?? 0) > MAX_WORKSPACE_DESCRIPTION_LENGTH ||
-    (dataSourceEnabled && formData.selectedDataSourceConnections.length === 0);
+    (formData.description?.length ?? 0) > MAX_WORKSPACE_DESCRIPTION_LENGTH;
 
   return (
     <>

src/plugins/workspace/public/components/workspace_creator/workspace_form_summary_panel.tsx

@@ -211,7 +211,6 @@ export const WorkspaceFormSummaryPanel = ({
         formId={formId}
         application={application}
         isSubmitting={isSubmitting}
-        dataSourceEnabled={dataSourceEnabled}
       />
     </EuiCard>
   );