Skip to content

Commit a659762

Browse files
opensearch-trigger-bot[bot]github-actions[bot]opensearch-changeset-bot[bot]
authored
vis(vega): fix data url with signal not working (#10339) (#10559)
* vis(vega): fix data url with signal not working * Changeset file for PR #10339 created/updated --------- (cherry picked from commit ba02fa5) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
1 parent d2d58f6 commit a659762

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

changelogs/fragments/10339.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
fix:
2+
- Fix vega data url with signal not working ([#10339](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10339))

src/plugins/vis_type_vega/public/data_model/vega_parser.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -715,8 +715,8 @@ The URL is an identifier only. OpenSearch Dashboards and your browser will never
715715
this._findObjectDataUrls(elem, onFind, key);
716716
}
717717
} else if (_.isPlainObject(obj)) {
718-
if (key === 'data' && _.isPlainObject(obj.url)) {
719-
// Assume that any "data": {"url": {...}} is a request for data
718+
if (key === 'data' && _.isPlainObject(obj.url) && _.isEmpty(obj.url.signal)) {
719+
// Assume that any "data": {"url": {...}} without "signal" is a request for data
720720
if (obj.values !== undefined || obj.source !== undefined) {
721721
throw new Error(
722722
i18n.translate(

0 commit comments

Comments
 (0)