fixed an issue that the initial result summary generated with the wrong data (#9611)

* fixed an issue that the initial discover summary generated with stale data

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #9611 created/updated

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: ruanyl

changelogs/fragments/9611.yml

@@ -0,0 +1,2 @@
+fix:
+- Initial result summary generated with the wrong data ([#9611](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9611))

src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx

@@ -68,7 +68,12 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) =>
   const [feedback, setFeedback] = useState(FeedbackStatus.NONE);
   const [isEnabledByCapability, setIsEnabledByCapability] = useState(false);
   const selectedDataset = useRef(query.queryString.getQuery()?.dataset);
-  const { queryState, isQuerySummaryCollapsed, isSummaryAgentAvailable } = useQueryAssist();
+  const {
+    queryState,
+    isQuerySummaryCollapsed,
+    isSummaryAgentAvailable,
+    updateQueryState,
+  } = useQueryAssist();
 
   const [results, setResults] = useState<any[]>([]);
   // the question and answer used last time to generate summary
@@ -144,14 +149,22 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) =>
     return () => subscription.unsubscribe();
   }, [query.queryString]);
 
+  useEffect(() => {
+    return () => {
+      // reset the state when unmount, so when navigating away and
+      // back to discover, it won't use stale state
+      updateQueryState({ question: '', generatedQuery: '' });
+    };
+  }, [updateQueryState]);
+
   useEffect(() => {
     const subscription = search.df.df$
       .pipe(
         distinctUntilChanged(),
         filter((value) => !isEmpty(value) && !isEmpty(value?.fields))
       )
       .subscribe((df) => {
-        if (df) {
+        if (df && currentQueryStateRef.current.question) {
           setResults(convertResult(df));
         }
       });