-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Updated the version check logic during start of OSD server. #10818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updated the version check logic during start of OSD server. #10818
Conversation
Signed-off-by: Nishanth Vinjam <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10818 +/- ##
==========================================
- Coverage 60.54% 60.54% -0.01%
==========================================
Files 4514 4514
Lines 121393 121393
Branches 20273 20273
==========================================
- Hits 73502 73498 -4
- Misses 42742 42744 +2
- Partials 5149 5151 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nvinjam-amazon I believe enforing exact version match is by intention, could you elaborate the motivation of changing to major version match? Also this doesn't seem is a |
|
@ruanyl This is mainly the issue with release process. Recently we have introduced a CLI flag |
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration