Skip to content

[Explore Vis] apply color group panel and save key instead of hex value for colors #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Explore Vis] apply color group panel and save key instead of hex value for colors #10830

wants to merge 2 commits into from

Conversation

@Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Oct 30, 2025 •
edited
Loading

Description

This pr :

  1. applies color group panel and can save key instead of hex value for colors
  2. align status color with theme color

Screenshot

截屏2025-10-30 14 56 52
2025-10-30.14.47.25.mov
2025-10-30.14.09.57.mp4

Testing the changes

Changelog

  • feat: apply color group panel and save key instead of hex value for colors

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#10830 created/updated
ba6e5e7
@Qxisylolo Qxisylolo marked this pull request as ready for review October 30, 2025 07:06
@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.76%. Comparing base (889338b) to head (d516856).

Files with missing lines Patch % Lines
...tyle_panel/color_group_panel/color_group_panel.tsx 50.00% 2 Missing ⚠️
...mponents/visualizations/bar_gauge/to_expression.ts 50.00% 1 Missing ⚠️
.../components/visualizations/metric/to_expression.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10830   +/-   ##
=======================================
  Coverage   60.75%   60.76%           
=======================================
  Files        4533     4533           
  Lines      122209   122212    +3     
  Branches    20483    20482    -1     
=======================================
+ Hits        74251    74257    +6     
+ Misses      42719    42715    -4     
- Partials     5239     5240    +1
Flag Coverage Δ
Linux_1 26.57% <ø> (ø)
Linux_2 38.92% <ø> (ø)
Linux_3 39.44% <ø> (-0.01%) ⬇️
Linux_4 33.75% <69.23%> (+<0.01%) ⬆️
Windows_1 26.58% <ø> (ø)
Windows_2 38.90% <ø> (ø)
Windows_3 39.45% <ø> (+<0.01%) ⬆️
Windows_4 33.75% <69.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qxisylolo Qxisylolo force-pushed the feat/apply_color_group_panel branch 2 times, most recently from 150287d to ca9cd7f Compare November 3, 2025 09:42
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Nov 3, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#10830 created/updated
3e58fc3
@Qxisylolo
use color group panel
f05f67f 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
fix conflicts
d516856 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo Qxisylolo force-pushed the feat/apply_color_group_panel branch from 3e58fc3 to d516856 Compare November 13, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

@Maosaic Maosaic Awaiting requested review from Maosaic Maosaic is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@d-buckner d-buckner Awaiting requested review from d-buckner d-buckner is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@TackAdam TackAdam Awaiting requested review from TackAdam TackAdam is a code owner

@ruchidh ruchidh Awaiting requested review from ruchidh ruchidh is a code owner

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy sumukhswamy is a code owner

@paulstn paulstn Awaiting requested review from paulstn paulstn is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

distinguished-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Qxisylolo