Fix recent queries not working for DQL and Lucene #10837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Recent Queries button was not working for DQL and Lucene query languages due to two issues in the query editor: 1. The RecentQueriesTable component visibility was gated by the useQueryEditor flag, which is false for DQL/Lucene queries. 2. The onSubmit function never called addToQueryHistory(), so queries were not being saved to history in the first place. This fix removes the useQueryEditor condition from the table visibility and adds the addToQueryHistory() call in onSubmit to ensure all query languages are properly saved and displayed in recent queries. Fixes opensearch-project#10810 Signed-off-by: Andrew Hopp <[email protected]>
ahopp
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
d-buckner,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
raintygao,
ruanyl,
sejli,
virajsanghvi,
wanglam,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
ahopp
requested review from
TackAdam,
paulstn,
ps48,
ruchidh and
sumukhswamy
as code owners
Contributor
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Contributor
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 10837.yml under folder changelogs/fragments to complete this PR. File still missing. |
Signed-off-by: Andrew Hopp <[email protected]>
Contributor
Author
|
Updated PR to align to template and added changeset file for PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10837 +/- ##
==========================================
- Coverage 60.71% 60.70% -0.01%
==========================================
Files 4524 4524
Lines 121776 121777 +1
Branches 20369 20369
==========================================
- Hits 73935 73929 -6
- Misses 42640 42644 +4
- Partials 5201 5204 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@ananzh, @ashwin-pc, or @abbyhu2000? Thoughts on the code changes? |
Contributor
Author
|
Or maybe @TackAdam or @d-buckner? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Recent Queries button not working for DQL and Lucene query languages in the Discover plugin.
Issues Resolved
Fixes #10810
Root Cause
The Recent Queries feature was broken for DQL (kuery) and Lucene queries due to two issues in the query editor (
src/plugins/data/public/ui/query_editor/query_editor.tsx):Visibility condition bug: The
RecentQueriesTablecomponent visibility was gated byisRecentQueryVisible && useQueryEditor. TheuseQueryEditorflag isfalsefor DQL and Lucene queries, preventing the dropdown from ever showing.Missing history save: The
onSubmitfunction never calledqueryString.addToQueryHistory(), so queries were not being saved to history in the first place.Changelog
src/plugins/data/public/ui/query_editor/query_editor.tsxLine 487: Removed
&& useQueryEditorfromRecentQueriesTablevisibility conditionisVisible={isRecentQueryVisible && useQueryEditor}isVisible={isRecentQueryVisible}Lines 157-160: Added
queryString.addToQueryHistory()call inonSubmitfunctionTesting
Tested locally with DQL and Lucene queries in the Discover plugin:
DQL:
Lucene:
Check List