-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove theme update modal #9776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: abbyhu2000 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9776 +/- ##
=======================================
Coverage 61.95% 61.95%
=======================================
Files 3826 3825 -1
Lines 92600 92589 -11
Branches 14752 14752
=======================================
- Hits 57367 57361 -6
+ Misses 31524 31519 -5
Partials 3709 3709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hailong-am
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a issue in functional test repo to make sure all cypress are still working? I remember there might have some setup to disable the model when doing cypress rest
the setting is set in local storage, it should be safe when we remove it from yml |
|
opensearch-project/opensearch-dashboards-functional-test#1790 <-- PR to remove theme modal related code in cypress tests @ruanyl @Hailong-am |
* remove theme modal Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR opensearch-project#9776 created/updated --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Remove theme modal as we do not need it anymore.
Add the theme update modal PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4715/files
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration