Skip to content

Conversation

@abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented May 7, 2025

Description

Remove theme modal as we do not need it anymore.
Add the theme update modal PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4715/files

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: Remove theme update modal

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <[email protected]>
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.95%. Comparing base (70ab5be) to head (99777e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9776   +/-   ##
=======================================
  Coverage   61.95%   61.95%           
=======================================
  Files        3826     3825    -1     
  Lines       92600    92589   -11     
  Branches    14752    14752           
=======================================
- Hits        57367    57361    -6     
+ Misses      31524    31519    -5     
  Partials     3709     3709           
Flag Coverage Δ
Linux_1 28.88% <ø> (ø)
Linux_2 56.42% <ø> (ø)
Linux_3 39.60% <ø> (ø)
Linux_4 28.80% <ø> (-0.01%) ⬇️
Windows_1 28.90% <ø> (ø)
Windows_2 56.38% <ø> (ø)
Windows_3 39.61% <ø> (ø)
Windows_4 28.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a issue in functional test repo to make sure all cypress are still working? I remember there might have some setup to disable the model when doing cypress rest

@Hailong-am
Copy link
Collaborator

Can you create a issue in functional test repo to make sure all cypress are still working? I remember there might have some setup to disable the model when doing cypress rest

https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/bb3e06812d0d7bb24233a581e12063a9df9a2d06/cypress/integration/plugins/security-dashboards-plugin/readonly.js#L64-L65

the setting is set in local storage, it should be safe when we remove it from yml

@ruanyl ruanyl merged commit 1b10e50 into opensearch-project:main May 8, 2025
76 checks passed
@abbyhu2000
Copy link
Member Author

opensearch-project/opensearch-dashboards-functional-test#1790 <-- PR to remove theme modal related code in cypress tests @ruanyl @Hailong-am

Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request May 13, 2025
* remove theme modal

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR opensearch-project#9776 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants