clean up completedReplications when SegmentReplicator.cancel is invoked (#18856)

guojialiang92 · web-flow · commit 2f2a3a749238 · 2025-09-16T09:26:03.000-07:00
Signed-off-by: guojialiang &lt;guojialiang.2012@bytedance.com&gt;
diff --git a/server/src/main/java/org/opensearch/indices/replication/SegmentReplicator.java b/server/src/main/java/org/opensearch/indices/replication/SegmentReplicator.java
@@ -399,6 +399,7 @@ void cancel(ShardId shardId, String reason) {
         onGoingMergedSegmentReplications.cancelForShard(shardId, reason);
         replicationCheckpointStats.remove(shardId);
         primaryCheckpoint.remove(shardId);
+        completedReplications.remove(shardId);
     }
 
     SegmentReplicationTarget get(ShardId shardId) {

Original file line number	Diff line number	Diff line change
`@@ -399,6 +399,7 @@ void cancel(ShardId shardId, String reason) {`
`399`	`399`	`onGoingMergedSegmentReplications.cancelForShard(shardId, reason);`
`400`	`400`	`replicationCheckpointStats.remove(shardId);`
`401`	`401`	`primaryCheckpoint.remove(shardId);`
	`402`	`+ completedReplications.remove(shardId);`
`402`	`403`	`}`
`403`	`404`
`404`	`405`	`SegmentReplicationTarget get(ShardId shardId) {`