Register s3.client.*.disable_chunked_encoding in repository-s3 plugin settings

Signed-off-by: Aman Gautam <[email protected]>

Author: Gautam-aman

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3ClientSettings.java

@@ -680,7 +680,7 @@ public boolean equals(final Object o) {
             && Objects.equals(endpoint, that.endpoint)
             && protocol == that.protocol
             && proxySettings.equals(that.proxySettings)
-            && Objects.equals(disableChunkedEncoding, that.disableChunkedEncoding)
+            && disableChunkedEncoding == that.disableChunkedEncoding
             && Objects.equals(region, that.region)
             && Objects.equals(signerOverride, that.signerOverride)
             && Objects.equals(irsaCredentials, that.irsaCredentials);

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3RepositoryPlugin.java

@@ -363,6 +363,8 @@ public List<Setting<?>> getSettings() {
             S3Repository.ACCESS_KEY_SETTING,
             S3Repository.SECRET_KEY_SETTING,
             S3ClientSettings.SIGNER_OVERRIDE,
+            // Fixed the bug in this line
+            S3ClientSettings.DISABLE_CHUNKED_ENCODING,
             S3ClientSettings.REGION,
             S3ClientSettings.ROLE_ARN_SETTING,
             S3ClientSettings.IDENTITY_TOKEN_FILE_SETTING,

plugins/repository-s3/src/test/java/org/opensearch/repositories/s3/S3RepositoryPluginTests.java

@@ -75,6 +75,9 @@ public void testGetExecutorBuilders() throws IOException {
                 );
             }
             assertTrue(plugin.getSettings().contains(S3Repository.S3_ASYNC_HTTP_CLIENT_TYPE));
+            // New assertion for your bug fix
+            assertTrue(plugin.getSettings().contains(S3ClientSettings.DISABLE_CHUNKED_ENCODING));
+
         } finally {
             if (threadPool != null) {
                 terminate(threadPool);