Bump org.apache.maven:maven-model from 3.9.6 to 3.9.12 (#20438)

* Bump org.apache.maven:maven-model from 3.9.6 to 3.9.12

Bumps org.apache.maven:maven-model from 3.9.6 to 3.9.12.

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-model
  dependency-version: 3.9.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Rakshit Goyal <[email protected]>

Author: 2 people

CHANGELOG.md

@@ -39,6 +39,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Fix indexing regression and bug fixes for grouping criteria. ([20145](https://github.com/opensearch-project/OpenSearch/pull/20145))
 - LeafReader should not remove SubReaderWrappers incase IndexWriter encounters a non aborting Exception ([#20193](https://github.com/opensearch-project/OpenSearch/pull/20193))
 - Fix Netty deprecation warnings in transport-reactor-netty4 module ([20429](https://github.com/opensearch-project/OpenSearch/pull/20429))
+- Adding validation to check if Remote Store Translog Repo is enabled ([#20450](https://github.com/opensearch-project/OpenSearch/pull/20450))
 
 ### Dependencies
 - Bump `com.google.auth:google-auth-library-oauth2-http` from 1.38.0 to 1.41.0 ([#20183](https://github.com/opensearch-project/OpenSearch/pull/20183))
@@ -71,6 +72,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Bump `org.wiremock:wiremock-standalone` from 3.6.0 to 3.13.2 ([#20406](https://github.com/opensearch-project/OpenSearch/pull/20406))
 - Bump `tj-actions/changed-files` from 47.0.0 to 47.0.1 ([#20408](https://github.com/opensearch-project/OpenSearch/pull/20408))
 - Bump `reactor-netty` to 1.3.2, `reactor` to 3.8.2 ([#20419](https://github.com/opensearch-project/OpenSearch/pull/20419))
+- Bump `org.apache.maven:maven-model` from 3.9.6 to 3.9.12 ([#20438](https://github.com/opensearch-project/OpenSearch/pull/20438))
 - Bump `dnsjava:dnsjava` from 3.6.3 to 3.6.4 ([#20440](https://github.com/opensearch-project/OpenSearch/pull/20440))
 - Bump `com.netflix.nebula.ospackage-base` from 12.1.1 to 12.2.0 ([#20439](https://github.com/opensearch-project/OpenSearch/pull/20439))
 - Bump OpenTelemetry to 1.58.0 ([#20441](https://github.com/opensearch-project/OpenSearch/pull/20441))

buildSrc/build.gradle

@@ -117,7 +117,7 @@ dependencies {
   api 'de.thetaphi:forbiddenapis:3.10'
   api 'com.avast.gradle:gradle-docker-compose-plugin:0.17.12'
   api "org.yaml:snakeyaml:${props.getProperty('snakeyaml')}"
-  api 'org.apache.maven:maven-model:3.9.6'
+  api 'org.apache.maven:maven-model:3.9.12'
   api 'com.networknt:json-schema-validator:1.2.0'
   api 'org.jruby.jcodings:jcodings:1.0.58'
   api 'org.jruby.joni:joni:2.2.3'

server/src/main/java/org/opensearch/index/IndexSettings.java

@@ -1553,7 +1553,7 @@ public boolean isAssignedOnRemoteNode() {
      * Returns if remote translog store is enabled for this index.
      */
     public boolean isRemoteTranslogStoreEnabled() {
-        return remoteStoreTranslogRepository != null && remoteStoreTranslogRepository.isEmpty() == false;
+        return remoteStoreTranslogRepository != null && remoteStoreTranslogRepository.isEmpty() == false && assignedOnRemoteNode;
     }
 
     /**

server/src/test/java/org/opensearch/index/IndexSettingsTests.java

@@ -491,6 +491,26 @@ public void testMaxAdjacencyMatrixFiltersSetting() {
         );
     }
 
+    public void testRemoteTranslogStoreDisabledWhenNodeHasNoRemoteStoreAttributes() {
+        // Corner case: Index settings have repository configured but node attributes don't have remote repositories setup
+        IndexMetadata metadata = newIndexMeta(
+            "index",
+            Settings.builder()
+                .put(IndexMetadata.SETTING_VERSION_CREATED, Version.CURRENT)
+                .put(IndexMetadata.SETTING_REMOTE_TRANSLOG_STORE_REPOSITORY, "tlog-store")
+                .put(IndexSettings.INDEX_REMOTE_TRANSLOG_BUFFER_INTERVAL_SETTING.getKey(), "200ms")
+                .build()
+        );
+        // Node settings without remote store attributes
+        Settings nodeSettings = Settings.EMPTY;
+        IndexSettings settings = new IndexSettings(metadata, nodeSettings);
+
+        // Verify repository is configured in index settings
+        assertEquals("tlog-store", settings.getRemoteStoreTranslogRepository());
+        // But remote translog should be disabled since node doesn't have remote store attributes
+        assertFalse("Remote translog should be disabled when node has no remote store attributes", settings.isRemoteTranslogStoreEnabled());
+    }
+
     public void testMaxRegexLengthSetting() {
         IndexMetadata metadata = newIndexMeta(
             "index",

server/src/test/java/org/opensearch/index/seqno/ReplicationTrackerTests.java

@@ -1572,7 +1572,7 @@ public void testInSyncIdsAreIgnoredIfNotValidatedByClusterManagerWithRemoteTrans
             .put(IndexMetadata.SETTING_REMOTE_STORE_ENABLED, "true")
             .put(IndexMetadata.SETTING_REMOTE_TRANSLOG_STORE_REPOSITORY, "translog-repo")
             .build();
-        final ReplicationTracker tracker = newTracker(primaryId, settings);
+        final ReplicationTracker tracker = newTracker(primaryId, updatedGlobalCheckpoint::set, () -> 0L, settings, true);
         tracker.updateFromClusterManager(randomNonNegativeLong(), ids(active.keySet()), routingTable(initializing.keySet(), primaryId));
         tracker.activatePrimaryMode(NO_OPS_PERFORMED);
         initializing.keySet().forEach(k -> markAsTrackingAndInSyncQuietly(tracker, k.getId(), NO_OPS_PERFORMED));