Optimize sub aggregation using bulk collection lucene apis #19737
Conversation
…ing sub aggregation Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
jainankitk
requested review from
Bukhtawar,
CEHENKLE,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326 and
kotwanikunal
as code owners
jainankitk
requested review from
a team,
Rishikesh1159,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 729bf0a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| cnt = stream.intoArray(upToExclusive, docBuffer); | ||
| sub.collect(docBuffer, upToBucketIndex); |
There was a problem hiding this comment.
I think the issue here is when cnt is less than docBuffer.length, sub.collect(docBuffer, upToBucketIndex); will still iterate through entire docBuffer.
So we can either pass in size e.g.
sub.collect(docBuffer, cnt, upToBucketIndex);
Or create a new array, which I think will be sub optimal.
There was a problem hiding this comment.
Yes, I realized this yesterday. Missed adding a comment. Due to this issue advanceExact might be getting invoked for target > doc resulting in an error
|
❌ Gradle check result for 09d5c71: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2 participants
Description
Followup to #19573 for leveraging bulk collection lucene apis. Currently has changes for couple of unmerged due to which the diff looks much bigger.
Related Issues
Related to #19384
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.