Skip to content

Commit abdec4e

Browse files
committed
converted to become a parameterized test
Signed-off-by: Santhosh Gandhe <1909520+san81@users.noreply.github.com>
1 parent 0749d35 commit abdec4e

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

data-prepper-plugins/date-processor/src/test/java/org/opensearch/dataprepper/plugins/processor/date/DateProcessorConfigTest.java

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -69,24 +69,28 @@ void isValidMatchAndFromTimestampReceived_should_return_false_if_from_time_recei
6969
assertThat(dateProcessorConfig.isValidMatchAndFromTimestampReceived(), equalTo(false));
7070
}
7171

72-
@Test
73-
void testValidAndInvalidOutputFormats() throws NoSuchFieldException, IllegalAccessException {
74-
// Use a string with invalid pattern characters (] and [ are reserved and will always fail)
75-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "invalid[pattern]format");
76-
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(false));
77-
78-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "epoch_second");
79-
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(true));
80-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "epoch_milli");
81-
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(true));
82-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "epoch_nano");
83-
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(true));
84-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "epoch_micro");
72+
@ParameterizedTest
73+
@ValueSource(strings = {
74+
"epoch_second",
75+
"epoch_milli",
76+
"epoch_nano",
77+
"epoch_micro",
78+
"yyyy-MM-dd'T'HH:mm:ss.nnnnnnnnnXXX"
79+
})
80+
void testValidOutputFormats(String outputFormat) throws NoSuchFieldException, IllegalAccessException {
81+
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", outputFormat);
8582
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(true));
86-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "epoch_xyz");
83+
}
84+
85+
@ParameterizedTest
86+
@ValueSource(strings = {
87+
"invalid[pattern]format",
88+
"epoch_xyz",
89+
"epoch_invalid"
90+
})
91+
void testInvalidOutputFormats(String outputFormat) throws NoSuchFieldException, IllegalAccessException {
92+
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", outputFormat);
8793
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(false));
88-
setField(DateProcessorConfig.class, dateProcessorConfig, "outputFormat", "yyyy-MM-dd'T'HH:mm:ss.nnnnnnnnnXXX");
89-
assertThat(dateProcessorConfig.isValidOutputFormat(), equalTo(true));
9094
}
9195

9296
@Test

0 commit comments

Comments
 (0)