Update the setting defaults in sql plugin #11598
Conversation
LantaoJin
requested review from
AMoo-Miki,
dlvenable,
epugh,
kolchfa-aws,
natebower and
sumobrian
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
added
Doc review
|
Any review progress? @kolchfa-aws |
|
@LantaoJin This PR is in my queue for review and will be reviewed in the next couple of days. Thanks. |
|
Thank you, @LantaoJin. Could you review my changes and verify that everything is technically accurate. |
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
This reverts commit b7fa236. Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
force-pushed
the
pr/update_configs_ppl
branch
from
5a308ef to
45c403b
Compare
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
@LantaoJin I have applied the changes in the commit that you reverted as suggestions. Please see my comments and let me know if you have any questions.
|
@LantaoJin I have updated my suggestions based on your comments. Please accept the suggestions by going into the Files tab and adding all suggestions to a batch and then committing them. After that, we can put the PR in editorial review. |
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Lantao Jin <[email protected]>
Done, thanks a lot! |
Signed-off-by: Nathan Bower <[email protected]>
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thank you, @LantaoJin!
3 participants
Description
Update the setting defaults in sql plugin: correct descriptions and add missing ones.
Issues Resolved
Closes #[Replace this text, including the brackets, with the issue number. Leave "Closes #" so the issue is closed properly.]
Version
3.4.0
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.