Skip to content

Commit e3e9d7f

Browse files
Update release note and minor change to toast message. (#770) (#772)
* Update 2.8 release note with original PR numbers to follow the standard. Signed-off-by: Xuesong Luo <[email protected]> * If refresh all index fails, show red index names in the toast. Signed-off-by: Xuesong Luo <[email protected]> --------- Signed-off-by: Xuesong Luo <[email protected]> (cherry picked from commit 1b86a6f) Co-authored-by: Xuesong Luo <[email protected]>
1 parent 7418c21 commit e3e9d7f

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

public/containers/RefreshAction/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,16 @@ export default function RefreshActionModal<T>(props: RefreshActionModalProps) {
8888
if (!selectedItems.length) {
8989
if (!blockedItems.length) {
9090
setLoading(false);
91+
} else if (blockedItems.length === 1) {
92+
coreServices.notifications.toasts.addDanger({
93+
title: `Unable to refresh indexes.`,
94+
text: `Cannot refresh all open indexes because [${blockedItems.join(", ")}] is in red status.`,
95+
});
96+
onClose();
9197
} else {
9298
coreServices.notifications.toasts.addDanger({
9399
title: `Unable to refresh indexes.`,
94-
text: `Cannot refresh all open indexes because one or more indexes are in red status.`,
100+
text: `Cannot refresh all open indexes because [${blockedItems.join(", ")}] are in red status.`,
95101
});
96102
onClose();
97103
}

public/pages/Indices/containers/IndicesActions/IndicesActions.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1262,7 +1262,7 @@ describe("<IndicesActions /> spec", () => {
12621262

12631263
await waitFor(() => {
12641264
expect(coreServicesMock.notifications.toasts.addDanger).toHaveBeenCalledWith({
1265-
text: "Cannot refresh all open indexes because one or more indexes are in red status.",
1265+
text: "Cannot refresh all open indexes because [red_index] is in red status.",
12661266
title: "Unable to refresh indexes.",
12671267
});
12681268
});

release-notes/opensearch-index-management-dashboards-plugin.release-notes-2.8.0.0.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
Compatible with OpenSearch 2.8.0
44

55
### Features
6-
* Feature: Add refresh index operation to UI ([#762](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/762))
6+
* Feature: Add refresh index operation to UI ([#761](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/761))
77
* Feature: Add clear cache operation to UI ([#728](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/728))
8-
* Feature: Add flush index operation to UI ([#757](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/757),[#719](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/719),[#752](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/752),[#755](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/755))
9-
* Feature: Add notification settings page and runtime notification option for long running index operations ([#764](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/764),[#763](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/763))
10-
* Feature: Composable templates enhancement ([#759](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/759))
8+
* Feature: Add flush index operation to UI ([#713](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/713),[#718](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/718),[#751](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/751),[#753](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/753))
9+
* Feature: Add notification settings page and runtime notification option for long running index operations ([#731](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/731),[#732](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/732))
10+
* Feature: Composable templates enhancement ([#730](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/730))
1111

1212
### Bug Fixes
1313
* Update path parameter to follow RFC/generic HTTP convention. ([#742](https://github.com/opensearch-project/index-management-dashboards-plugin/pull/742))

0 commit comments

Comments
 (0)