Use _list/indices API instead of _cat/index API in CatIndexTool (#3243)

* Use _list/indices API instead of _cat/index API in CatIndexTool

Signed-off-by: zane-neo <[email protected]>

* change assert to avoid flaky in test

Signed-off-by: zane-neo <[email protected]>

* add example of responsestr and change default size to 100

Signed-off-by: zane-neo <[email protected]>

* add ListIndexTool and revert CatIndexTool change

Signed-off-by: zane-neo <[email protected]>

* Use random string instead of number sequence

Signed-off-by: zane-neo <[email protected]>

* fix failure IT

Signed-off-by: zane-neo <[email protected]>

* change comment to _list/indices API rest action file

Signed-off-by: zane-neo <[email protected]>

* add page size parameter from input and change sef4j to log4j

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Add UT for ListIndexTool

Signed-off-by: zane-neo <[email protected]>

* rebase main

Signed-off-by: zane-neo <[email protected]>

* Fix UT failure

Signed-off-by: zane-neo <[email protected]>

* Change resource name to fix IT failure

Signed-off-by: zane-neo <[email protected]>

* Add more UTs to increase coverage

Signed-off-by: zane-neo <[email protected]>

* Remove CatIndexTool to keep only ListIndexTool

Signed-off-by: zane-neo <[email protected]>

* Remove temp file

Signed-off-by: zane-neo <[email protected]>

* Remove CatIndexTool

Signed-off-by: zane-neo <[email protected]>

* Fix jacoco result not updated to latest commit issue

Signed-off-by: zane-neo <[email protected]>

* Change file path to under plugin module

Signed-off-by: zane-neo <[email protected]>

* fix failure tests

Signed-off-by: zane-neo <[email protected]>

* Remove assert to ensure IT pass

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>

Author: zane-neo

.github/workflows/CI-workflow.yml

@@ -84,23 +84,18 @@ jobs:
                                echo "::add-mask::$COHERE_KEY" &&
                                echo "build and run tests" && ./gradlew build -x spotlessJava &&
                                echo "Publish to Maven Local" && ./gradlew publishToMavenLocal -x spotlessJava &&
-                               echo "Multi Nodes Integration Testing" && ./gradlew integTest -PnumNodes=3 -x spotlessJava'
+                               echo "Multi Nodes Integration Testing" && ./gradlew integTest -PnumNodes=3 -x spotlessJava
+                               echo "Run Jacoco test coverage" && && ./gradlew jacocoTestReport && cp -v plugin/build/reports/jacoco/test/jacocoTestReport.xml ./jacocoTestReport.xml'
           plugin=`basename $(ls plugin/build/distributions/*.zip)`
           echo $plugin
           mv -v plugin/build/distributions/$plugin ./
           echo "build-test-linux=$plugin" >> $GITHUB_OUTPUT
 
-      - name: Upload Coverage Report
-        uses: codecov/codecov-action@v3
-        with:
-          flags: ml-commons
-          token: ${{ secrets.CODECOV_TOKEN }}
-
       - uses: actions/upload-artifact@v4
+        if: ${{ matrix.os }} == "ubuntu-latest"
         with:
-          name: ml-plugin-linux-${{ matrix.java }}
-          path: ${{ steps.step-build-test-linux.outputs.build-test-linux }}
-          if-no-files-found: error
+          name: coverage-report-${{ matrix.os }}-${{ matrix.java }}
+          path: ./jacocoTestReport.xml
 
 
   Test-ml-linux-docker:
@@ -200,6 +195,24 @@ jobs:
           flags: ml-commons
           token: ${{ secrets.CODECOV_TOKEN }}
 
+  Precommit-codecov:
+    needs: Build-ml-linux
+    strategy:
+      matrix:
+        java: [21, 23]
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: coverage-report-${{ matrix.os }}-${{ matrix.java }}
+          path: ./
+      - name: Upload Coverage Report
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: ./jacocoTestReport.xml
+
   Build-ml-windows:
     strategy:
       matrix:

client/build.gradle

@@ -17,6 +17,7 @@ dependencies {
     implementation project(path: ":${rootProject.name}-spi", configuration: 'shadow')
     implementation project(path: ":${rootProject.name}-common", configuration: 'shadow')
     compileOnly group: 'org.opensearch', name: 'opensearch', version: "${opensearch_version}"
+    testImplementation "org.opensearch.test:framework:${opensearch_version}"
     testImplementation group: 'junit', name: 'junit', version: '4.13.2'
     testImplementation group: 'org.mockito', name: 'mockito-core', version: '5.15.2'