Skip to content

Add name validation to index prefix #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2025
Merged

Add name validation to index prefix #4332

merged 5 commits into from
Oct 24, 2025
+1,145 −189

Conversation

@b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Oct 20, 2025

Description

Add name validation to index prefix and remove sensitive logs

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from e7d6707 to 1272ad6 Compare October 21, 2025 00:15
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 00:18 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.94017% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.08%. Comparing base (c4ec014) to head (eeaa0dd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...emorycontainer/memory/MemoryProcessingService.java 72.63% 12 Missing and 14 partials ⚠️
...rycontainer/memory/TransportAddMemoriesAction.java 45.71% 16 Missing and 3 partials ⚠️
...ontainer/TransportDeleteMemoryContainerAction.java 76.00% 3 Missing and 3 partials ⚠️
...earch/ml/helper/MemoryContainerPipelineHelper.java 53.84% 6 Missing ⚠️
...ontainer/TransportUpdateMemoryContainerAction.java 58.33% 5 Missing ⚠️
...ontainer/TransportCreateMemoryContainerAction.java 81.81% 2 Missing ⚠️
...l/action/session/TransportCreateSessionAction.java 66.66% 2 Missing ⚠️
...on/memorycontainer/memory/MemorySearchService.java 75.00% 1 Missing ⚠️
...ycontainer/memory/TransportDeleteMemoryAction.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4332      +/-   ##
============================================
- Coverage     80.12%   80.08%   -0.04%     
- Complexity    10175    10184       +9     
============================================
  Files           855      855              
  Lines         44239    44358     +119     
  Branches       5113     5133      +20     
============================================
+ Hits          35447    35525      +78     
- Misses         6642     6667      +25     
- Partials       2150     2166      +16
Flag Coverage Δ
ml-commons 80.08% <70.94%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 1272ad6 to 2343286 Compare October 21, 2025 07:10
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 07:12 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 21, 2025 08:17 — with GitHub Actions Failure
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 2343286 to 950732e Compare October 21, 2025 08:17
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 21, 2025 08:19 — with GitHub Actions Inactive
@b4sjoo
Log reasons on error
1e2dff1 
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 96ede8b to 3567b84 Compare October 24, 2025 08:59
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 24, 2025 09:00 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 09:00 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 09:00 — with GitHub Actions Inactive
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from 3567b84 to eb3eb13 Compare October 24, 2025 11:59
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 12:02 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 12:02 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 12:02 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 12:02 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 24, 2025 13:10 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 24, 2025 16:55 — with GitHub Actions Failure
@b4sjoo
change status code
eeaa0dd 
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo force-pushed the feature/agentic_memory_new branch from f3c7ca7 to eeaa0dd Compare October 24, 2025 19:27
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 19:31 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env October 24, 2025 19:31 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 19:31 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env October 24, 2025 19:31 — with GitHub Actions Inactive
@b4sjoo b4sjoo merged commit f8b403b into opensearch-project:main Oct 24, 2025
9 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2025
@b4sjoo @github-actions
Add name validation to index prefix (#4332)
43f4996 
(cherry picked from commit f8b403b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 24, 2025
Merged
b4sjoo pushed a commit that referenced this pull request Oct 24, 2025
@opensearch-trigger-bot
Add name validation to index prefix (#4332) (#4346)
a7bcaf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@dhrubo-os dhrubo-os dhrubo-os left review comments

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@pyek-bot pyek-bot Awaiting requested review from pyek-bot pyek-bot is a code owner

Assignees

No one assigned

Labels

backport 3.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@b4sjoo @Zhangxunmt @ylwu-amzn @dhrubo-os