fix: resolve Cypress timeout errors in forecasting tests (#1863)

Fixes two flaky test failures:
1. Navigation clicks blocked by welcome/theme overlays
2. Data grid expand button visibility issues

Changes:
- Disable welcome modal via localStorage (home:welcome:show)
- Disable theme modal via localStorage (home:newThemeModal:show)
- Implement retry mechanism (5 attempts) for expand button clicks
- Add multiple hover techniques (mouseenter, mouseover, mousemove)
- Remove strict visibility assertion on expand button
- Reduce wait times and add scrollIntoView for better reliability

The retry logic handles cases where expand buttons have display:none
by attempting clicks, hovers, and visibility checks with backoff.

Testing done:
- local run passes

Signed-off-by: kaituo <[email protected]>

Author: kaituo

cypress/integration/plugins/anomaly-detection-dashboards-plugin/forecaster_list_spec.js

@@ -17,9 +17,8 @@
 //  8. Delete a forecaster from the list page
 // ============================================================================
 
-import { AD_FIXTURE_BASE_PATH } from '../../../utils/constants';
+import { AD_FIXTURE_BASE_PATH, BASE_PATH } from '../../../utils/constants';
 import { setStorageItem } from '../../../utils/plugins/dashboards-assistant/helpers';
-import { BASE_PATH } from '../../../utils/constants';
 
 const setupIndexWithData = (indexName) => {
   // Create index mapping first
@@ -82,6 +81,8 @@ context('list forecaster workflow', () => {
   const TEST_INDEX_NAME_2 = 'sample-forecast-index-2';
 
   let restoreTenantSwitchModal;
+  let restoreWelcomeModal;
+  let restoreThemeModal;
 
   beforeEach(() => {
     // disable the tenant switch modal
@@ -90,6 +91,16 @@ context('list forecaster workflow', () => {
       'opendistro::security::tenant::show_popup',
       'false'
     );
+    restoreWelcomeModal = setStorageItem(
+      localStorage,
+      'home:welcome:show',
+      'false'
+    );
+    restoreThemeModal = setStorageItem(
+      localStorage,
+      'home:newThemeModal:show',
+      'false'
+    );
     // Visit OSD
     // requrired otherwise we encounter connection issue in later test
     cy.visit(`${BASE_PATH}/app/home`);
@@ -107,6 +118,12 @@ context('list forecaster workflow', () => {
     if (restoreTenantSwitchModal) {
       restoreTenantSwitchModal();
     }
+    if (restoreWelcomeModal) {
+      restoreWelcomeModal();
+    }
+    if (restoreThemeModal) {
+      restoreThemeModal();
+    }
   });
 
   it('Full creation - based on real index', () => {
@@ -213,25 +230,44 @@ context('list forecaster workflow', () => {
     // Wait a moment for the cell to become active
     cy.wait(500);
 
-    // Try to trigger hover as well, in case that's needed
-    cy.get('@statusCell').trigger('mouseover');
-
-    // Check if the expand button is now visible, if not, try clicking again
-    cy.get('@statusCell').then(($cell) => {
-      const expandButton = $cell.find(
-        'button.euiDataGridRowCell__expandButtonIcon'
-      );
-      if (expandButton.length === 0 || !expandButton.is(':visible')) {
-        cy.log('Expand button not visible, trying to click cell again');
-        cy.get('@statusCell').click({ force: true });
-        cy.wait(500);
+    // Retry mechanism to handle the expand button visibility
+    const attemptExpandButtonClick = (retries = 5) => {
+      if (retries === 0) {
+        throw new Error('Failed to click expand button after multiple retries');
       }
-    });
 
-    // Find the now-visible expand button inside the cell.
+      cy.get('@statusCell').then(($cell) => {
+        const expandButton = $cell.find(
+          'button.euiDataGridRowCell__expandButtonIcon'
+        );
+
+        if (expandButton.length === 0) {
+          cy.log(`Expand button not found, retries left: ${retries}`);
+          cy.get('@statusCell').click({ force: true });
+          cy.wait(300);
+          attemptExpandButtonClick(retries - 1);
+        } else if (!expandButton.is(':visible')) {
+          cy.log(`Expand button not visible, retries left: ${retries}`);
+          // Try multiple hover techniques
+          cy.get('@statusCell')
+            .scrollIntoView()
+            .trigger('mouseenter', { force: true })
+            .trigger('mouseover', { force: true })
+            .trigger('mousemove', { force: true });
+          cy.wait(200);
+          attemptExpandButtonClick(retries - 1);
+        } else {
+          cy.log('Expand button is visible, clicking it');
+          cy.wrap(expandButton).click({ force: true });
+        }
+      });
+    };
+
+    attemptExpandButtonClick();
+
+    // Alias the button for later use
     cy.get('@statusCell')
       .find('button.euiDataGridRowCell__expandButtonIcon')
-      .should('be.visible')
       .as('expandButton');
 
     // Click the expand button to open the final popover.