Fix flaky tests in core dashboard. (#1371) (#1382)

opensearch-trigger-bot[bot] · SuZhou-Joe · web-flow · commit 6a453efccd3f · 2024-06-12T18:22:18.000+08:00
* feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: discover advanced settings Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: discover tabe spec Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * troubleshoot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 5af3c7a) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
diff --git a/.github/workflows/cypress-workflow-bundle-snapshot-based-ci-groups.yml b/.github/workflows/cypress-workflow-bundle-snapshot-based-ci-groups.yml
@@ -6,6 +6,7 @@ on:
       - '.github/workflows/cypress-workflow-bundle-snapshot-based-ci-groups.yml'
       - 'cypress/**/core-opensearch-dashboards/**'
       - 'cypress/utils/dashboards/**'
+      - 'package.json'
       - '.github/actions/start-opensearch/action.yml'
 
   push:
@@ -14,6 +15,7 @@ on:
       - '.github/workflows/cypress-workflow-bundle-snapshot-based-ci-groups.yml'
       - 'cypress/**/core-opensearch-dashboards/**'
       - 'cypress/utils/dashboards/**'
+      - 'package.json'
       - '.github/actions/start-opensearch/action.yml'
 
 env:
diff --git a/.github/workflows/cypress-workflow-bundle-snapshot-based.yml b/.github/workflows/cypress-workflow-bundle-snapshot-based.yml
@@ -5,11 +5,13 @@ on:
     paths:
       - 'cypress/**/core-opensearch-dashboards/**'
       - 'cypress/utils/dashboards/**'
+      - '.github/workflows/cypress-workflow-bundle-snapshot-based.yml'
   push:
     branches: ['**']
     paths:
       - 'cypress/**/core-opensearch-dashboards/**'
       - 'cypress/utils/dashboards/**'
+      - '.github/workflows/cypress-workflow-bundle-snapshot-based.yml'
 
 jobs:
   tests-with-security:
diff --git a/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_advanced_settings.spec.js b/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_advanced_settings.spec.js
@@ -216,7 +216,7 @@ describe('discover_advanced_setting', () => {
     it('check legacy table respects Number of rows setting', function () {
       cy.switchDiscoverTable('legacy');
       cy.wait(2000); // Intentional Wait to account for low performant env
-      cy.get('[aria-label="Next"]').should('have.length', 5);
+      cy.get('[aria-label="Toggle row details"]').should('have.length', 5);
     });
 
     after(() => {
diff --git a/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_histogram.spec.js b/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_histogram.spec.js
@@ -68,6 +68,7 @@ describe('discover histogram', { scrollBehavior: false }, () => {
     );
     cy.deleteIndex('long-window-logstash-0');
     cy.deleteSavedObjectByType('index-pattern');
+    cy.clearCache();
   });
 
   it('should visualize monthly data with different day intervals', () => {
diff --git a/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_table.spec.js b/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_table.spec.js
@@ -505,6 +505,7 @@ describe('discover_table', () => {
     cy.reload();
     cy.deleteIndexPattern('nestedindex');
     cy.deleteIndex('nestedindex');
+    cy.clearCache();
     miscUtils.visitPage(
       `app/data-explorer/discover#/?_g=(filters:!(),time:(from:'2015-09-19T13:31:44.000Z',to:'2015-09-24T01:31:44.000Z'))`
     );
diff --git a/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js b/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js
@@ -58,6 +58,11 @@ describe('shared links', () => {
     cy.fleshTenantSettings();
   });
 
+  after(() => {
+    cy.deleteIndex(indexSet.join(','));
+    cy.clearCache();
+  });
+
   describe('shared links with state in query', () => {
     it('should allow for copying the snapshot URL', function () {
       const url = `http://localhost:5601/app/data-explorer/discover#/?_a=(discover:(columns:!(_source),isDirty:!f,sort:!()),metadata:(indexPattern:'logstash-*',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'2015-09-19T13:31:44.000Z',to:'2015-09-24T01:31:44.000Z'))&_q=(filters:!(),query:(language:kuery,query:''))`;
@@ -125,9 +130,9 @@ describe('shared links', () => {
     });
 
     after(() => {
-      cy.setAdvancedSetting({
-        'state:storeStateInSessionStorage': false,
-      });
+      CURRENT_TENANT.newTenant = 'global';
+      cy.fleshTenantSettings();
+      cy.deleteSavedObjectByType('config');
     });
 
     it('should allow for copying the snapshot URL', function () {
diff --git a/cypress/utils/commands.js b/cypress/utils/commands.js
@@ -4,6 +4,7 @@
  */
 
 import { BASE_PATH, IM_API, BACKEND_BASE_PATH } from './constants';
+import { devToolsRequest } from './helpers';
 
 export const DisableLocalCluster = !!Cypress.env('DISABLE_LOCAL_CLUSTER'); // = hideLocalCluster
 
@@ -681,3 +682,10 @@ Cypress.Commands.add('removeSampleDataFromDataSource', (dataSourceTitle) => {
     .should('be.visible')
     .click();
 });
+
+Cypress.Commands.add('clearCache', () => {
+  devToolsRequest(`/_cache/clear?query=true&request=true`, 'POST');
+  devToolsRequest(`/_flush`, 'POST');
+  devToolsRequest(`/_forcemerge`, 'POST');
+  cy.wait(5000);
+});
