Merge test

Signed-off-by: Lin Wang <[email protected]>

Author: wanglam

cypress/integration/plugins/dashboards-assistant/mds_query_enhancements_suggest_anomaly_detector_spec.js

@@ -88,7 +88,7 @@ const testSuggestAD = (url) => {
         .click();
     });
 
-    it('test before and after', () => {
+    it('should create detector successfully', () => {
       cy.get('button[aria-label="OpenSearch assistant trigger button"]', {
         timeout: 60000,
       }).click();
@@ -122,37 +122,21 @@ const testSuggestAD = (url) => {
 
       // Check main UI elements are present
       cy.get('[data-test-subj="detectorNameTextInputFlyout"]').should('exist'); // Check for initial elements with adequate timeouts
-      cy.get('#add-anomaly-detector__title', { timeout: 10000 })
-        .should('be.visible')
-        .should('contain', 'Suggested anomaly detector');
-
-      cy.get('[data-test-subj="detectionInterval"]', { timeout: 5000 }).should(
-        'exist'
-      );
-      cy.get('[data-test-subj="windowDelay"]', { timeout: 5000 }).should(
-        'exist'
+      cy.get('#add-anomaly-detector__title').should(
+        'contain',
+        'Suggested anomaly detector'
       );
+      cy.get('[data-test-subj="detectionInterval"]').should('exist');
+      cy.get('[data-test-subj="windowDelay"]').should('exist');
 
-      // Expand the accordion with proper waiting
       cy.get('[id="detectorDetailsAccordion"]')
-        .should('exist')
         .parent()
         .find('[data-test-subj="accordionTitleButton"]')
-        .should('be.visible')
         .click();
 
-      // Wait for animation to complete
-      cy.wait(1000);
-
-      // Test empty name validation with safer interactions
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]')
-        .should('be.visible')
-        .clear();
-
-      // Use separate commands instead of chaining for more stability
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]')
-        .should('be.visible')
-        .blur({ force: true });
+      // Test empty name validation
+      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').clear();
+      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').blur();
 
       // Wait and check for error message with retry
       cy.wait(500);
@@ -226,106 +210,6 @@ const testSuggestAD = (url) => {
       cy.wait('@startDetector');
     });
 
-    it.skip('should create detector successfully', () => {
-      cy.get('button[aria-label="OpenSearch assistant trigger button"]', {
-        timeout: 60000,
-      }).click();
-      cy.contains('Suggest anomaly detector').click();
-
-      cy.intercept('POST', 'w/*/api/assistant/agent/_execute**', (req) => {
-        req.reply(() => {
-          return {
-            statusCode: 200,
-            headers: {
-              'content-type': 'application/json',
-            },
-            body: {
-              inference_results: [
-                {
-                  output: [
-                    {
-                      name: 'response',
-                      result:
-                        '{"index":"opensearch_dashboards_sample_data_logs","categoryField":"geo.src","aggregationField":"bytes,memory,phpmemory","aggregationMethod":"sum,avg,max","dateFields":"utc_time,timestamp"}',
-                    },
-                  ],
-                },
-              ],
-            },
-          };
-        });
-      }).as('suggestParameters');
-
-      cy.wait('@suggestParameters');
-
-      // Check main UI elements are present
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').should('exist');
-      cy.get('#add-anomaly-detector__title').should(
-        'contain',
-        'Suggested anomaly detector'
-      );
-      cy.get('[data-test-subj="detectionInterval"]').should('exist');
-      cy.get('[data-test-subj="windowDelay"]').should('exist');
-
-      cy.get('[id="detectorDetailsAccordion"]')
-        .parent()
-        .find('[data-test-subj="accordionTitleButton"]')
-        .click();
-
-      // Test empty name validation
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').clear();
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').blur();
-      cy.contains('Detector name cannot be empty').should('be.visible');
-
-      // Test valid name
-      cy.get('[data-test-subj="detectorNameTextInputFlyout"]').type(
-        'test-detector-name' + Math.floor(Math.random() * 100) + 1
-      );
-      cy.contains('Detector name cannot be empty').should('not.exist');
-
-      // Test interval input
-      cy.get('[data-test-subj="detectionInterval"]').clear().type('15');
-
-      // Test window delay input
-      cy.get('[data-test-subj="windowDelay"]').clear().type('5');
-
-      // Mock the create detector API call
-      cy.intercept('POST', 'w/*/api/anomaly_detectors/detectors/*', (req) => {
-        req.reply({
-          statusCode: 200,
-          body: {
-            ok: true,
-            response: {
-              id: 'test-detector-id',
-            },
-          },
-        });
-      }).as('createDetector');
-
-      // Mock the start detector API call
-      cy.intercept(
-        'POST',
-        'w/*/api/anomaly_detectors/detectors/test-detector-id/start/*',
-        (req) => {
-          req.reply({
-            statusCode: 200,
-            body: {
-              ok: true,
-              response: {
-                _id: 'test-detector-id',
-              },
-            },
-          });
-        }
-      ).as('startDetector');
-
-      // Click create button
-      cy.contains('button', 'Create detector').click();
-      cy.wait('@createDetector');
-      cy.contains('Detector created').should('be.visible');
-      cy.wait('@startDetector');
-    });
-
     it('should handle suggest parameters error gracefully', () => {
       cy.get('button[aria-label="OpenSearch assistant trigger button"]', {
         timeout: 60000,