[Security Analytics] Fix cypress tests (#1765)

* [Security Analytics] Fix cypress tests

Signed-off-by: vikhy-aws <[email protected]>

* [Security Analytics] Fix flakiness in cypress tests

Signed-off-by: vikhy-aws <[email protected]>

---------

Signed-off-by: vikhy-aws <[email protected]>

Author: vikhy-aws

cypress/integration/plugins/security-analytics-dashboards-plugin/1_detectors.spec.js

@@ -153,9 +153,11 @@ const fillDetailsForm = (
     getDataSourceField().sa_selectComboboxItem(dataSource);
   }
 
-  getDataSourceField().focus().blur();
+  getDataSourceField().focus();
+  getDataSourceField().blur();
   getLogTypeField().sa_selectComboboxItem(getLogTypeLabel(cypressLogTypeDns));
-  getLogTypeField().focus().blur();
+  getLogTypeField().focus();
+  getLogTypeField().blur();
 };
 
 const createDetector = (detectorName, dataSource, expectFailure) => {
@@ -283,7 +285,8 @@ describe('Detectors', () => {
 
     it('...should validate name field', () => {
       getNameField().should('be.empty');
-      getNameField().focus().blur();
+      getNameField().focus();
+      getNameField().blur();
       getNameField()
         .parentsUntil('.euiFormRow__fieldWrapper')
         .siblings()
@@ -409,7 +412,8 @@ describe('Detectors', () => {
       fillDetailsForm(detectorName, cypressIndexDns);
 
       getDataSourceField().sa_selectComboboxItem(cypressIndexWindows);
-      getDataSourceField().focus().blur();
+      getDataSourceField().focus();
+      getDataSourceField().blur();
 
       cy.get('[data-test-subj="define-detector-diff-log-types-warning"]')
         .should('be.visible')

cypress/integration/plugins/security-analytics-dashboards-plugin/2_rules.spec.js

@@ -246,7 +246,8 @@ describe('Rules', () => {
       );
 
       getNameField().should('be.empty');
-      getNameField().focus().blur();
+      getNameField().focus();
+      getNameField().blur();
       getNameField().sa_containsError('Rule name is required');
 
       getNameField()
@@ -305,7 +306,8 @@ describe('Rules', () => {
       );
 
       getAuthorField().should('be.empty');
-      getAuthorField().focus().blur();
+      getAuthorField().focus();
+      getAuthorField().blur();
 
       let invalidAuthor = '';
 
@@ -327,7 +329,8 @@ describe('Rules', () => {
 
     it('...should validate log type field', () => {
       getLogTypeField().should('be.empty');
-      getLogTypeField().focus().blur();
+      getLogTypeField().focus();
+      getLogTypeField().blur();
       getLogTypeField().sa_containsError('Log type is required');
 
       getLogTypeField().sa_selectComboboxItem(
@@ -338,27 +341,34 @@ describe('Rules', () => {
 
     it('...should validate rule level field', () => {
       getRuleLevelField().should('be.empty');
-      getRuleLevelField().focus().blur();
+      getRuleLevelField().focus();
+      getRuleLevelField().blur();
       getRuleLevelField().sa_containsError('Rule level is required');
 
       getRuleLevelField().sa_selectComboboxItem(SAMPLE_RULE.severity);
-      getRuleLevelField().focus().blur().sa_shouldNotHaveError();
+      getRuleLevelField().focus();
+      getRuleLevelField().blur();
+      getRuleLevelField().sa_shouldNotHaveError();
     });
 
     it('...should validate rule status field', () => {
       getRuleStatusField().sa_containsValue(SAMPLE_RULE.status);
-      getRuleStatusField().focus().blur().sa_shouldNotHaveError();
+      getRuleStatusField().focus();
+      getRuleStatusField().blur();
+      getRuleStatusField().sa_shouldNotHaveError();
 
       getRuleStatusField().sa_clearCombobox();
-      getRuleStatusField().focus().blur();
+      getRuleStatusField().focus();
+      getRuleStatusField().blur();
       getRuleStatusField().sa_containsError('Rule status is required');
     });
 
     it('...should validate selection', () => {
       getSelectionPanelByIndex(0).within(() => {
         getSelectionNameField().should('have.value', 'Selection_1');
         getSelectionNameField().sa_clearValue();
-        getSelectionNameField().focus().blur();
+        getSelectionNameField().focus();
+        getSelectionNameField().blur();
         getSelectionNameField()
           .parentsUntil('.euiFormRow__fieldWrapper')
           .siblings()
@@ -403,7 +413,8 @@ describe('Rules', () => {
     it('...should validate selection map value field', () => {
       getSelectionPanelByIndex(0).within(() => {
         getMapValueField().should('be.empty');
-        getMapValueField().focus().blur();
+        getMapValueField().focus();
+        getMapValueField().blur();
         getMapValueField()
           .parentsUntil('.euiFormRow__fieldWrapper')
           .siblings()
@@ -423,7 +434,8 @@ describe('Rules', () => {
       getSelectionPanelByIndex(0).within(() => {
         getListRadioField().click({ force: true });
         getMapListField().should('be.empty');
-        getMapListField().focus().blur();
+        getMapListField().focus();
+        getMapListField().blur();
         getMapListField()
           .parentsUntil('.euiFormRow')
           .contains('Value is required');
@@ -450,7 +462,8 @@ describe('Rules', () => {
 
     it('...should validate tag field', () => {
       getTagField(0).should('be.empty');
-      getTagField(0).type('wrong.tag').focus().blur();
+      getTagField(0).type('wrong.tag').focus();
+      getTagField(0).type('wrong.tag').blur();
       getTagField(0)
         .parents('.euiFormRow__fieldWrapper')
         .contains("Tags must start with 'attack.'");

cypress/integration/plugins/security-analytics-dashboards-plugin/3_alerts.spec.js

@@ -272,9 +272,6 @@ describe('Alerts', () => {
         2
       );
       const documentLines = document.split('\n');
-      cy.get(
-        '[data-test-subj="finding-details-flyout-document-toggle-0"]'
-      ).click({ force: true });
       cy.get('[data-test-subj="finding-details-flyout-rule-document-0"]')
         .get('[class="euiCodeBlock__line"]')
         .each((lineElement, lineIndex) => {