ism-plugin: fix tests #1030
Merged
ism-plugin: fix tests #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ... 1. 'Close indices' to 'Close' 2. 'Open indices' to 'Open' 3. 'indices' to 'indexes' 4. Sample slack webhook to meet current validation ... to match current tech writing guidelines. Signed-off-by: Rohit Ashiwal <[email protected]>
r1walz
requested review from
Hailong-am,
SuZhou-Joe,
raintygao,
ruanyl,
wanglam and
xluo-aws
as code owners
Member
|
The cypress workflow somehow stuck for long time... @r1walz maybe paste your local test result so others can help approve and merge this in |
bowenlan-amzn
approved these changes
Feb 1, 2024
Hailong-am
approved these changes
Feb 1, 2024
Collaborator
Hailong-am
left a comment
Hailong-am
left a comment
There was a problem hiding this comment.
LGTM, can you provide your local test run result?
ruanyl
approved these changes
Feb 1, 2024
Member
|
@r1walz FYI added |
Contributor
Author
|
All failing tests are now passing after change: managed_indices_spec.js.mp4indices_spec.js.mp4notification_settings.js.mp4rollups_spec.js.mp4 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
Change ... 1. 'Close indices' to 'Close' 2. 'Open indices' to 'Open' 3. 'indices' to 'indexes' 4. Sample slack webhook to meet current validation ... to match current tech writing guidelines. Signed-off-by: Rohit Ashiwal <[email protected]> (cherry picked from commit 10443bd)
r1walz
added a commit
to r1walz/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 1, 2024
Change ... 1. 'Close indices' to 'Close' 2. 'Open indices' to 'Open' 3. 'indices' to 'indexes' 4. Sample slack webhook to meet current validation ... to match current tech writing guidelines. Signed-off-by: Rohit Ashiwal <[email protected]> (cherry picked from commit 10443bd) Signed-off-by: Rohit Ashiwal <[email protected]>
Hailong-am
pushed a commit
that referenced
this pull request
Feb 1, 2024
Change ... 1. 'Close indices' to 'Close' 2. 'Open indices' to 'Open' 3. 'indices' to 'indexes' 4. Sample slack webhook to meet current validation ... to match current tech writing guidelines. (cherry picked from commit 10443bd) Signed-off-by: Rohit Ashiwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change ...
... to match current tech writing guidelines.
Issues Resolved
Same fixes can be applied to 2.x for fixing #1008
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.