Remove theme modal #1790
Open
Remove theme modal #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingyang(Abby) Hu <[email protected]>
abbyhu2000
requested review from
CCongWang,
Hailong-am,
SuZhou-Joe,
ananzh,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
raintygao,
ruanyl,
tianleh,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
7 tasks
Hailong-am
approved these changes
May 8, 2025
ruanyl
approved these changes
May 9, 2025
Member
|
@abbyhu2000 It seems dashboard assistant tests are failed, not sure if it's related to your changes? |
Collaborator
|
@ruanyl I think the reason the assistant test failed was due to using a legacy 3.0.0-beta1 OSD package. We may need to bump the main branch version to 3.1.0 after the OSD version is bumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove theme modal related code as we removed the theme modal in OSD: opensearch-project/OpenSearch-Dashboards#9776
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.