Skip to content

Remove theme modal #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove theme modal #1790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...ss/integration/plugins/dashboards-assistant/conversation_chatbot_save_to_notebook_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const FINAL_ANSWER =
if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
describe('Assistant conversation save to notebook spec', () => {
let restoreShowHome;
let restoreNewThemeModal;
let restoreTenantSwitchModal;

beforeEach(() => {
Expand All @@ -22,12 +21,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
'home:welcome:show',
'false'
);
// Hide new theme modal
restoreNewThemeModal = setStorageItem(
localStorage,
'home:newThemeModal:show',
'false'
);
restoreTenantSwitchModal = setStorageItem(
sessionStorage,
'opendistro::security::tenant::show_popup',
Expand Down Expand Up @@ -57,9 +50,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
if (restoreShowHome) {
restoreShowHome();
}
if (restoreNewThemeModal) {
restoreNewThemeModal();
}
if (restoreTenantSwitchModal) {
restoreTenantSwitchModal();
}
Expand Down
2 changes: 0 additions & 2 deletions cypress/integration/plugins/dashboards-assistant/mds_chatbot_agent_framework_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
cy.setDefaultDataSourceForAssistant();
// Set welcome screen tracking to false
localStorage.setItem('home:welcome:show', 'false');
// Set new theme modal to false
localStorage.setItem('home:newThemeModal:show', 'false');
});

after(() => {
Expand Down
10 changes: 0 additions & 10 deletions cypress/integration/plugins/dashboards-assistant/mds_chatbot_conversation_history_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { setStorageItem } from '../../../utils/plugins/dashboards-assistant/help
if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
describe('Assistant conversation history spec', () => {
let restoreShowHome;
let restoreNewThemeModal;
let dataSourceId;

before(() => {
Expand All @@ -21,12 +20,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
'home:welcome:show',
'false'
);
// Hide new theme modal
restoreNewThemeModal = setStorageItem(
localStorage,
'home:newThemeModal:show',
'false'
);
// Visit OSD
cy.visit(`${BASE_PATH}/app/home`);

Expand All @@ -38,9 +31,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
if (restoreShowHome) {
restoreShowHome();
}
if (restoreNewThemeModal) {
restoreNewThemeModal();
}
// Close assistant flyout
cy.get('button[aria-label="toggle chat flyout icon"]').click();
});
Expand Down
3 changes: 0 additions & 3 deletions cypress/integration/plugins/dashboards-assistant/mds_chatbot_feedback_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
cy.setDefaultDataSourceForAssistant();
// Set welcome screen tracking to false
localStorage.setItem('home:welcome:show', 'false');
// Set new theme modal to false
localStorage.setItem('home:newThemeModal:show', 'false');
});

beforeEach(() => {
Expand All @@ -27,7 +25,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
after(() => {
cy.clearDataSourceForAssistant();
localStorage.removeItem('home:welcome:show');
localStorage.removeItem('home:newThemeModal:show');
});

describe('conversation feedback', () => {
Expand Down
3 changes: 0 additions & 3 deletions cypress/integration/plugins/dashboards-assistant/mds_chatbot_interaction_trace_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
cy.setDefaultDataSourceForAssistant();
// Set welcome screen tracking to false
localStorage.setItem('home:welcome:show', 'false');
// Set new theme modal to false
localStorage.setItem('home:newThemeModal:show', 'false');

cy.visit(`${BASE_PATH}/app/home`);
// cy.waitForLoader();
Expand All @@ -34,7 +32,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
after(() => {
cy.clearDataSourceForAssistant();
localStorage.removeItem('home:welcome:show');
localStorage.removeItem('home:newThemeModal:show');
});

describe('Trace page', () => {
Expand Down
2 changes: 0 additions & 2 deletions cypress/integration/plugins/dashboards-assistant/mds_chatbot_sidecar_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ if (Cypress.env('DASHBOARDS_ASSISTANT_ENABLED')) {
beforeEach(() => {
// Set welcome screen tracking to false
localStorage.setItem('home:welcome:show', 'false');
// Set new theme modal to false
localStorage.setItem('home:newThemeModal:show', 'false');
});

beforeEach(() => {
Expand Down
2 changes: 0 additions & 2 deletions cypress/integration/plugins/dashboards-assistant/mds_query_enhancements_chatbot_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ function addChatbotTestCase(url) {
beforeEach(() => {
// Set welcome screen tracking to false
localStorage.setItem('home:welcome:show', 'false');
// Set new theme modal to false
localStorage.setItem('home:newThemeModal:show', 'false');
const workspacePrefix = workspaceId ? `/w/${workspaceId}` : '';
cy.intercept('POST', `${workspacePrefix}/api/assistant/send_message*`).as(
'sendMessage'
Expand Down
1 change: 0 additions & 1 deletion cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ if (Cypress.env('SECURITY_ENABLED')) {
before(() => {
cy.server();
localStorage.setItem('home:welcome:show', false);
localStorage.setItem('home:newThemeModal:show', false);
});
it('Checks that the tenant switcher can switch tenants despite a different tenant being present in the tenant query parameter.', function () {
CURRENT_TENANT.newTenant = tenantName;
Expand Down
1 change: 0 additions & 1 deletion cypress/integration/plugins/security-dashboards-plugin/readonly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ if (Cypress.env('SECURITY_ENABLED')) {
'opendistro::security::tenant::saved',
`"${TEST_CONFIG.tenant.name}"`
);
window.localStorage.setItem('home:newThemeModal:show', false);
window.localStorage.setItem('home:welcome:show', false);
},
});
Expand Down
Loading