Update space type (#574)

Signed-off-by: Nathalie Jonathan <[email protected]>

Author: nathaliellenaa

CHANGELOG.md

@@ -35,6 +35,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Update pretrained_models_all_versions.json by @nathaliellenaa ([#560](https://github.com/opensearch-project/opensearch-py-ml/pull/560))
 - Upgrade torch version to fix security issue ([#561](https://github.com/opensearch-project/opensearch-py-ml/pull/561))
 - Upgrade numpy and python version ([#562](https://github.com/opensearch-project/opensearch-py-ml/pull/562))
+- Update space type mapping for sentence transformer models ([#574](https://github.com/opensearch-project/opensearch-py-ml/pull/574))
 
 ### Fixed
 - Fix for uploading models with function_name instead of model_task ([#553](https://github.com/opensearch-project/opensearch-py-ml/pull/553))

opensearch_py_ml/ml_models/sentencetransformermodel.py

@@ -61,10 +61,10 @@ class SentenceTransformerModel(BaseUploadModel):
         "msmarco-distilbert-base-tas-b": "innerproduct",
         "multi-qa-MiniLM-L6-cos-v1": "l2",
         "multi-qa-mpnet-base-dot-v1": "innerproduct",
-        "paraphrase-MiniLM-L3-v2": "cosine",
-        "paraphrase-multilingual-MiniLM-L12-v2": "cosine",
-        "paraphrase-mpnet-base-v2": "cosine",
-        "distiluse-base-multilingual-cased-v1": "cosine",
+        "paraphrase-MiniLM-L3-v2": "cosinesimil",
+        "paraphrase-multilingual-MiniLM-L12-v2": "cosinesimil",
+        "paraphrase-mpnet-base-v2": "cosinesimil",
+        "distiluse-base-multilingual-cased-v1": "cosinesimil",
     }
 
     def __init__(

tests/ml_models/test_sentencetransformermodel_pytest.py

@@ -276,7 +276,7 @@ def test_make_model_config_json_for_onnx():
         "embedding_dimension": 384,
         "pooling_mode": "MEAN",
         "normalize_result": False,
-        "additional_config": {"space_type": "cosine"},
+        "additional_config": {"space_type": "cosinesimil"},
     }
 
     clean_test_folder(TEST_FOLDER)
@@ -313,7 +313,7 @@ def test_overwrite_fields_in_model_config():
         "embedding_dimension": 128,
         "pooling_mode": "MAX",
         "normalize_result": False,
-        "additional_config": {"space_type": "cosine"},
+        "additional_config": {"space_type": "cosinesimil"},
     }
 
     clean_test_folder(TEST_FOLDER)