fixes

Signed-off-by: Nils Bandener <[email protected]>

Author: nibix

CHANGELOG.md

@@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [GRPC] Fix compilation errors from core protobuf version bump to 0.23.0 ([#5763](https://github.com/opensearch-project/security/pull/5763))
 - Modularized PrivilegesEvaluator ([#5791](https://github.com/opensearch-project/security/pull/5791))
 - [Resource Sharing] Adds post support for update sharing info API ([#5799](https://github.com/opensearch-project/security/pull/5799))
+- Cleaned up use of PrivilegesEvaluatorResponse ([#5804](https://github.com/opensearch-project/security/pull/5804))
 
 ### Maintenance
 - Bump `org.junit.jupiter:junit-jupiter` from 5.13.4 to 5.14.1 ([#5678](https://github.com/opensearch-project/security/pull/5678), [#5764](https://github.com/opensearch-project/security/pull/5764))

src/test/java/org/opensearch/security/privileges/SystemIndexAccessEvaluatorTest.java

@@ -179,7 +179,7 @@ PrivilegesEvaluationContext ctx(String action) {
 
     @After
     public void after() {
-        verifyNoMoreInteractions(auditLog, irr, request, task, log);
+        verifyNoMoreInteractions(auditLog, irr, request, task);
     }
 
     @Test
@@ -316,7 +316,7 @@ public void testUnprotectedActionOnSystemIndex_systemIndexPermissionEnabled_With
             user
         );
         // unprotected action is not allowed on a system index
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test
@@ -394,18 +394,12 @@ public void testDisableCacheOrRealtimeOnSystemIndex_systemIndexPermissionEnabled
             actionPrivileges,
             user
         );
-        assertThat(response, is(nullValue()));
+        assertThat(response.isAllowed(), is(false));
         response = evaluator.evaluate(searchRequest, null, UNPROTECTED_ACTION, resolved, ctx(UNPROTECTED_ACTION), actionPrivileges, user);
-        assertThat(response, is(nullValue()));
+        assertThat(response.isAllowed(), is(false));
         response = evaluator.evaluate(realtimeRequest, null, UNPROTECTED_ACTION, resolved, ctx(UNPROTECTED_ACTION), actionPrivileges, user);
-        assertThat(response, is(nullValue()));
-
-        verify(searchRequest).requestCache(Boolean.FALSE);
-        verify(realtimeRequest).realtime(Boolean.FALSE);
+        assertThat(response.isAllowed(), is(false));
 
-        verify(log, times(2)).isDebugEnabled();
-        verify(log).debug("Disable search request cache for this request");
-        verify(log).debug("Disable realtime for this request");
         verify(auditLog).logSecurityIndexAttempt(request, UNPROTECTED_ACTION, null);
         verify(auditLog).logSecurityIndexAttempt(searchRequest, UNPROTECTED_ACTION, null);
         verify(auditLog).logSecurityIndexAttempt(realtimeRequest, UNPROTECTED_ACTION, null);
@@ -415,8 +409,6 @@ public void testDisableCacheOrRealtimeOnSystemIndex_systemIndexPermissionEnabled
             user.getSecurityRoles(),
             TEST_SYSTEM_INDEX
         );
-        verify(log).debug("Disable search request cache for this request");
-        verify(log).debug("Disable realtime for this request");
     }
 
     @Test
@@ -529,7 +521,7 @@ public void testProtectedActionOnRegularIndex_systemIndexDisabled() {
             user
         );
 
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test
@@ -548,7 +540,7 @@ public void testProtectedActionOnRegularIndex_systemIndexPermissionDisabled() {
             user
         );
 
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test
@@ -567,7 +559,7 @@ public void testProtectedActionOnRegularIndex_systemIndexPermissionEnabled() {
             user
         );
 
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test
@@ -586,7 +578,7 @@ public void testProtectedActionOnSystemIndex_systemIndexDisabled() {
             user
         );
 
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test
@@ -654,7 +646,7 @@ public void testProtectedActionOnSystemIndex_systemIndexPermissionEnabled_withSy
             user
         );
 
-        assertThat(response.isAllowed(), is(false));
+        assertThat(response, is(nullValue()));
     }
 
     @Test