Cleanup

Signed-off-by: Nils Bandener <[email protected]>

Author: nibix

src/integrationTest/java/org/opensearch/security/privileges/int_tests/IndexAuthorizationReadOnlyIntTests.java

@@ -867,28 +867,6 @@ public void search_alias_pattern_negation() throws Exception {
                     .reducedBy(user.indexMatcher("read"))
                     .whenEmpty(clusterConfig.allowsEmptyResultSets ? isOk() : isForbidden())
             );
-            /*
-            if (user != LIMITED_USER_NONE) {
-                if (clusterConfig.systemIndexPrivilegeEnabled) {
-                    // If the system index privilege is enabled, we might also see the system_index_plugin index (being included via the
-                    // alias)
-                    assertThat(
-                        httpResponse,
-                        containsExactly(index_a1, index_a2, index_a3, index_b1, index_c1).at("hits.hits[*]._index")
-                            .reducedBy(user.indexMatcher("read"))
-                            .whenEmpty(clusterConfig.allowsEmptyResultSets ? isOk() : isForbidden())
-                    );
-                } else {
-                    assertThat(
-                        httpResponse,
-                        containsExactly(index_a1, index_a2, index_a3, index_b1, index_c1).at("hits.hits[*]._index")
-                            .reducedBy(user.indexMatcher("read"))
-                            .whenEmpty(clusterConfig.allowsEmptyResultSets ? isOk() : isForbidden())
-                    );
-                }
-            } else {
-                assertThat(httpResponse, isForbidden());
-            }*/
         }
     }
 

src/integrationTest/java/org/opensearch/security/privileges/int_tests/IndexAuthorizationReadWriteIntTests.java

@@ -748,7 +748,6 @@ public void putDocument_bulk_alias() throws Exception {
             } else {
                 assertThat(httpResponse, isForbidden());
             }
-
         } finally {
             delete("index_aw1/_doc/put_doc_alias_bulk_test_1");
         }
@@ -868,7 +867,6 @@ public void deleteAlias_staticIndex() throws Exception {
                     assertThat(httpResponse, isForbidden());
                 }
             }
-
         } finally {
             delete(alias_bwx);
         }
@@ -1118,20 +1116,12 @@ public void rollover_explicitTargetIndex() throws Exception {
                   }
                 }""");
 
-            System.out.println(httpResponse.getBody());
-
             if (clusterConfig.legacyPrivilegeEvaluation) {
                 if (user.indexMatcher("manage_alias").covers(index_bw1) && user.indexMatcher("manage_index").covers(index_bw2)) {
                     assertThat(httpResponse, isOk());
                 } else {
                     assertThat(httpResponse, isForbidden());
                 }
-            } else {
-                if (user.indexMatcher("manage_alias").covers(alias_bwx) && user.indexMatcher("manage_index").covers(index_bw2)) {
-                    assertThat(httpResponse, isOk());
-                } else {
-                    assertThat(httpResponse, isForbidden());
-                }
             }
         } finally {
             delete(alias_bwx, index_bwx1);