-
Notifications
You must be signed in to change notification settings - Fork 343
[Resource Sharing] Show minimal example of hierarchy within the Resource Sharing Framework #5735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
Its important to note that this PR will not solve some other problems in relation to hierarchy:
|
|
The changes in this PR seek to make security more embedded behind-the-scenes and ease integrating with security within other OpenSearch plugins. A step towards eliminating the need for the ResourceAccessControlClient. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5735 +/- ##
==========================================
+ Coverage 73.49% 73.50% +0.01%
==========================================
Files 438 438
Lines 26744 26801 +57
Branches 3960 3974 +14
==========================================
+ Hits 19655 19700 +45
- Misses 5203 5215 +12
Partials 1886 1886
🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Description
In many plugin use-cases, they define relationships between a parent and child object such as a detector and the detector's results or a report definition and instances of a report.
This PR seeks to introduce a mechanism from
ResourceProviderwhere a plugin can let security know about this relationship for the purpose of authorization.For instance, in the Linux Filesystem read access to a folder gives a user read access to its descendants. Likewise, this PR seeks to introduce a mechanism where a user can be granted read access to a Report Definition and get access to read the associated instances.
The mechanism for this is through the Access Levels - i.e. action groups pertinent to a single sharable resource
For instance, consider the following pseudo definition for the access level to read a report definition
Enhancement
Issues Resolved
Related to #4500
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.