Skip to content

Commit 1b4014d

Browse files
authored
Remove dependency from async-query-core to datasources (#2891)
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
1 parent 44ff520 commit 1b4014d

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

async-query-core/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ dependencies {
4646
antlr "org.antlr:antlr4:4.7.1"
4747

4848
implementation project(':core')
49-
implementation project(':datasources') // TODO: dependency to datasources should be eliminated
5049
implementation 'org.json:json:20231013'
5150
implementation 'com.google.code.gson:gson:2.8.9'
5251
api group: 'com.amazonaws', name: 'aws-java-sdk-emrserverless', version: "${aws_java_sdk_version}"

async-query-core/src/test/java/org/opensearch/sql/spark/asyncquery/AsyncQueryCoreIntegTest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
import static org.mockito.ArgumentMatchers.eq;
1515
import static org.mockito.Mockito.verify;
1616
import static org.mockito.Mockito.when;
17-
import static org.opensearch.sql.datasources.glue.GlueDataSourceFactory.GLUE_INDEX_STORE_OPENSEARCH_AUTH;
18-
import static org.opensearch.sql.datasources.glue.GlueDataSourceFactory.GLUE_INDEX_STORE_OPENSEARCH_URI;
1917
import static org.opensearch.sql.spark.dispatcher.IndexDMLHandler.DML_QUERY_JOB_ID;
2018
import static org.opensearch.sql.spark.dispatcher.IndexDMLHandler.DROP_INDEX_JOB_ID;
2119

@@ -41,7 +39,6 @@
4139
import org.opensearch.sql.datasource.DataSourceService;
4240
import org.opensearch.sql.datasource.model.DataSourceMetadata;
4341
import org.opensearch.sql.datasource.model.DataSourceType;
44-
import org.opensearch.sql.datasources.auth.AuthenticationType;
4542
import org.opensearch.sql.spark.asyncquery.model.AsyncQueryExecutionResponse;
4643
import org.opensearch.sql.spark.asyncquery.model.AsyncQueryJobMetadata;
4744
import org.opensearch.sql.spark.asyncquery.model.AsyncQueryJobMetadata.AsyncQueryJobMetadataBuilder;
@@ -675,10 +672,7 @@ private void givenValidDataSourceMetadataExist() {
675672
.setName(DATASOURCE_NAME)
676673
.setConnector(DataSourceType.S3GLUE)
677674
.setProperties(
678-
ImmutableMap.<String, String>builder()
679-
.put(GLUE_INDEX_STORE_OPENSEARCH_URI, "https://open.search.cluster:9200/")
680-
.put(GLUE_INDEX_STORE_OPENSEARCH_AUTH, AuthenticationType.NOAUTH.getName())
681-
.build())
675+
ImmutableMap.<String, String>builder().put("PARAM_NAME", "PARAM_VALUE").build())
682676
.build());
683677
}
684678

0 commit comments

Comments
 (0)