Skip to content

Commit 7420c6e

Browse files
authored
Update clickbench queries with parameter bucket_nullable=false (#4732)
* Update clickbench query Signed-off-by: Heng Qian <[email protected]> * Spotless check Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]>
1 parent c9a8f47 commit 7420c6e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

116 files changed

+1983
-56
lines changed

integ-test/src/test/java/org/opensearch/sql/calcite/clickbench/PPLClickBenchIT.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
package org.opensearch.sql.calcite.clickbench;
77

8+
import static org.opensearch.sql.util.MatcherUtils.assertYamlEqualsIgnoreId;
9+
810
import java.io.IOException;
911
import java.util.Locale;
1012
import java.util.Map;
@@ -68,6 +70,11 @@ public void test() throws IOException {
6870
}
6971
String ppl = sanitize(loadFromFile("clickbench/queries/q" + i + ".ppl"));
7072
timing(summary, "q" + i, ppl);
73+
// V2 gets unstable scripts, ignore them when comparing plan
74+
if (isCalciteEnabled()) {
75+
String expected = loadExpectedPlan("clickbench/q" + i + ".yaml");
76+
assertYamlEqualsIgnoreId(expected, explainQueryYaml(ppl));
77+
}
7178
}
7279
}
7380
}

integ-test/src/test/resources/clickbench/queries/q10.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ SELECT RegionID, SUM(AdvEngineID), COUNT(*) AS c, AVG(ResolutionWidth), COUNT(DI
33
FROM hits GROUP BY RegionID ORDER BY c DESC LIMIT 10;
44
*/
55
source=hits
6-
| stats sum(AdvEngineID), count() as c, avg(ResolutionWidth), dc(UserID) by RegionID
6+
| stats bucket_nullable=false sum(AdvEngineID), count() as c, avg(ResolutionWidth), dc(UserID) by RegionID
77
| sort - c
8-
| head 10
8+
| head 10

integ-test/src/test/resources/clickbench/queries/q11.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ GROUP BY MobilePhoneModel ORDER BY u DESC LIMIT 10;
55
*/
66
source=hits
77
| where MobilePhoneModel != ''
8-
| stats dc(UserID) as u by MobilePhoneModel
8+
| stats bucket_nullable=false dc(UserID) as u by MobilePhoneModel
99
| sort - u
10-
| head 10
10+
| head 10

integ-test/src/test/resources/clickbench/queries/q12.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ GROUP BY MobilePhone, MobilePhoneModel ORDER BY u DESC LIMIT 10;
55
*/
66
source=hits
77
| where MobilePhoneModel != ''
8-
| stats dc(UserID) as u by MobilePhone, MobilePhoneModel
8+
| stats bucket_nullable=false dc(UserID) as u by MobilePhone, MobilePhoneModel
99
| sort - u
10-
| head 10
10+
| head 10

integ-test/src/test/resources/clickbench/queries/q13.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ GROUP BY SearchPhrase ORDER BY c DESC LIMIT 10;
44
*/
55
source=hits
66
| where SearchPhrase != ''
7-
| stats count() as c by SearchPhrase
7+
| stats bucket_nullable=false count() as c by SearchPhrase
88
| sort - c
9-
| head 10
9+
| head 10

integ-test/src/test/resources/clickbench/queries/q14.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ GROUP BY SearchPhrase ORDER BY u DESC LIMIT 10;
55
*/
66
source=hits
77
| where SearchPhrase != ''
8-
| stats dc(UserID) as u by SearchPhrase
8+
| stats bucket_nullable=false dc(UserID) as u by SearchPhrase
99
| sort - u
10-
| head 10
10+
| head 10

integ-test/src/test/resources/clickbench/queries/q15.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ GROUP BY SearchEngineID, SearchPhrase ORDER BY c DESC LIMIT 10;
55
*/
66
source=hits
77
| where SearchPhrase != ''
8-
| stats count() as c by SearchEngineID, SearchPhrase
8+
| stats bucket_nullable=false count() as c by SearchEngineID, SearchPhrase
99
| sort - c
10-
| head 10
10+
| head 10

integ-test/src/test/resources/clickbench/queries/q16.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
SELECT UserID, COUNT(*) FROM hits GROUP BY UserID ORDER BY COUNT(*) DESC LIMIT 10;
33
*/
44
source=hits
5-
| stats count() by UserID
5+
| stats bucket_nullable=false count() by UserID
66
| sort - `count()`
7-
| head 10
7+
| head 10

integ-test/src/test/resources/clickbench/queries/q17.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ SELECT UserID, SearchPhrase, COUNT(*)
33
FROM hits GROUP BY UserID, SearchPhrase ORDER BY COUNT(*) DESC LIMIT 10;
44
*/
55
source=hits
6-
| stats count() by UserID, SearchPhrase
6+
| stats bucket_nullable=false count() by UserID, SearchPhrase
77
| sort - `count()`
8-
| head 10
8+
| head 10

integ-test/src/test/resources/clickbench/queries/q18.ppl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
SELECT UserID, SearchPhrase, COUNT(*) FROM hits GROUP BY UserID, SearchPhrase LIMIT 10;
33
*/
44
source=hits
5-
| stats count() by UserID, SearchPhrase
6-
| head 10
5+
| stats bucket_nullable=false count() by UserID, SearchPhrase
6+
| head 10

0 commit comments

Comments
 (0)