hex max limit doc and unit tests

Signed-off-by: Asif Bashar <[email protected]>

Author: asifabashar

docs/user/ppl/functions/conversion.rst

@@ -133,7 +133,8 @@ Return type: Number
 
 
 You can use this function with the eval commands and as part of eval expressions.
-Base values can be between 2 and 36.
+Base values can be between 2 and 36. The maximum value supported for base 10 is +(2-2^-52)·2^1023 and minimum is -(2-2^-52)·2^1023.
+The maximum for other supported bases is 2^63-1 (or 7FFFFFFFFFFFFFFF)   and minimum is -2^63 (or -7FFFFFFFFFFFFFFF).
 
 You can use this function to convert a string representation of a binary number to return the corresponding number in base 10.
 

ppl/src/test/java/org/opensearch/sql/ppl/calcite/CalcitePPLToNumberFunctionTest.java

@@ -49,6 +49,86 @@ public void testNumberHex() {
     verifyPPLToSparkSQL(root, expectedSparkSql);
   }
 
+
+    @Test
+    public void testNumberHexMinLimit() {
+        String ppl =
+                "source=EMP | eval long_value = tonumber('-7FFFFFFFFFFFFFFF',16) | fields long_value|head"
+                        + " 1";
+        RelNode root = getRelNode(ppl);
+        String expectedLogical =
+                "LogicalSort(fetch=[1])\n"
+                        + "  LogicalProject(long_value=[TONUMBER('-7FFFFFFFFFFFFFFF':VARCHAR, 16)])\n"
+                        + "    LogicalTableScan(table=[[scott, EMP]])\n";
+        verifyLogical(root, expectedLogical);
+        String expectedResult = "long_value=-9.223372036854776E18\n";
+        verifyResult(root, expectedResult);
+
+        String expectedSparkSql =
+                "SELECT `TONUMBER`('-7FFFFFFFFFFFFFFF', 16) `long_value`\nFROM `scott`.`EMP`\nLIMIT 1";
+
+        verifyPPLToSparkSQL(root, expectedSparkSql);
+    }
+
+  @Test
+  public void testNumberHexMaxLimit() {
+    String ppl =
+        "source=EMP | eval long_value = tonumber('7FFFFFFFFFFFFFFF',16) | fields long_value|head"
+            + " 1";
+    RelNode root = getRelNode(ppl);
+    String expectedLogical =
+        "LogicalSort(fetch=[1])\n"
+            + "  LogicalProject(long_value=[TONUMBER('7FFFFFFFFFFFFFFF':VARCHAR, 16)])\n"
+            + "    LogicalTableScan(table=[[scott, EMP]])\n";
+    verifyLogical(root, expectedLogical);
+    String expectedResult = "long_value=9.223372036854776E18\n";
+    verifyResult(root, expectedResult);
+
+    String expectedSparkSql =
+        "SELECT `TONUMBER`('7FFFFFFFFFFFFFFF', 16) `long_value`\nFROM `scott`.`EMP`\nLIMIT 1";
+
+    verifyPPLToSparkSQL(root, expectedSparkSql);
+  }
+
+  @Test
+  public void testNumberHexOverNegativeMaxLimit() {
+    String ppl =
+        "source=EMP | eval long_value = tonumber('-FFFFFFFFFFFFFFFF',16) | fields long_value|head"
+            + " 1";
+    RelNode root = getRelNode(ppl);
+    String expectedLogical =
+        "LogicalSort(fetch=[1])\n"
+            + "  LogicalProject(long_value=[TONUMBER('-FFFFFFFFFFFFFFFF':VARCHAR, 16)])\n"
+            + "    LogicalTableScan(table=[[scott, EMP]])\n";
+    verifyLogical(root, expectedLogical);
+    String expectedResult = "long_value=1.0\n";
+    verifyResult(root, expectedResult);
+
+    String expectedSparkSql =
+        "SELECT `TONUMBER`('-FFFFFFFFFFFFFFFF', 16) `long_value`\nFROM `scott`.`EMP`\nLIMIT 1";
+
+    verifyPPLToSparkSQL(root, expectedSparkSql);
+  }
+
+  @Test
+  public void testNumberHexOverPositiveMaxLimit() {
+    String ppl =
+        "source=EMP | eval long_value = tonumber('FFFFFFFFFFFFFFFF',16) | fields long_value|head 1";
+    RelNode root = getRelNode(ppl);
+    String expectedLogical =
+        "LogicalSort(fetch=[1])\n"
+            + "  LogicalProject(long_value=[TONUMBER('FFFFFFFFFFFFFFFF':VARCHAR, 16)])\n"
+            + "    LogicalTableScan(table=[[scott, EMP]])\n";
+    verifyLogical(root, expectedLogical);
+    String expectedResult = "long_value=-1.0\n";
+    verifyResult(root, expectedResult);
+
+    String expectedSparkSql =
+        "SELECT `TONUMBER`('FFFFFFFFFFFFFFFF', 16) `long_value`\nFROM `scott`.`EMP`\nLIMIT 1";
+
+    verifyPPLToSparkSQL(root, expectedSparkSql);
+  }
+
   @Test
   public void testNumber() {
     String ppl = "source=EMP | eval int_value = tonumber('4598') | fields int_value|head 1";