Revert to sql-worker

Signed-off-by: Simeon Widdis <[email protected]>

Author: Swiddis

datasources/src/main/java/org/opensearch/sql/datasources/utils/Scheduler.java

@@ -13,7 +13,7 @@
 import org.opensearch.transport.client.node.NodeClient;
 import static org.opensearch.sql.opensearch.executor.OpenSearchQueryManager.SQL_WORKER_THREAD_POOL_NAME;
 
-/** The scheduler which schedule the task run in sql_worker thread pool. */
+/** The scheduler which schedule the task run in sql-worker thread pool. */
 @UtilityClass
 public class Scheduler {
   public static void schedule(NodeClient client, Runnable task) {

docs/dev/query-manager.md

@@ -31,4 +31,4 @@ Parser parse raw query as Statement and create AbstractPlan. Each AbstractPlan d
 ### Change of existing logic
 1. Remove the schedule logic in NIO thread. After the change,
    a. Parser will be executed in NIO thread.
-   b. QueryManager decide query execution strategy. e.g. OpenSearchQueryManager schedule the QueryExecution running in **sql_worker** thread pool.
+   b. QueryManager decide query execution strategy. e.g. OpenSearchQueryManager schedule the QueryExecution running in **sql-worker** thread pool.

docs/user/admin/settings.rst

@@ -223,19 +223,19 @@ The SQL plugin is integrated with the `OpenSearch Thread Pool Settings <https://
 There are two thread pools which can be configured on cluster setup via `settings.yml`::
 
     thread_pool:
-      sql_worker:
+      sql-worker:
         size: 30
         queue_size: 100
       sql_background_io:
         size: 30
         queue_size: 1000
 
-The ``sql_worker`` pool corresponds to compute resources related to running queries, such as compute-heavy evaluations on result sets.
+The ``sql-worker`` pool corresponds to compute resources related to running queries, such as compute-heavy evaluations on result sets.
 This directly maps to the number of queries that can be run concurrently.
 This is the primary pool you interact with externally.
 ``sql_background_io`` is a low-footprint pool for IO requests the plugin makes,
 and can be used to limit indirect load that SQL places on your cluster for Calcite-enabled operations.
-A ``sql_worker`` thread may spawn multiple background threads.
+A ``sql-worker`` thread may spawn multiple background threads.
 
 plugins.query.executionengine.spark.session.limit
 ==================================================

opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java

@@ -219,7 +219,7 @@ public void cleanup(OpenSearchRequest request) {
 
   @Override
   public void schedule(Runnable task) {
-    // at that time, task already running the sql_worker ThreadPool.
+    // at that time, task already running the sql-worker ThreadPool.
     task.run();
   }
 

opensearch/src/main/java/org/opensearch/sql/opensearch/executor/OpenSearchQueryManager.java

@@ -21,7 +21,7 @@ public class OpenSearchQueryManager implements QueryManager {
 
   private final NodeClient nodeClient;
 
-  public static final String SQL_WORKER_THREAD_POOL_NAME = "sql_worker";
+  public static final String SQL_WORKER_THREAD_POOL_NAME = "sql-worker";
   public static final String SQL_BACKGROUND_THREAD_POOL_NAME = "sql_background_io";
 
   @Override