[v3.0.0] Deprecate SQL Delete statement (#3337)

* Remove all delete statement related code and docs

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix spotless

Signed-off-by: Chen Dai <daichen@amazon.com>

* Remove doctest

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix broken delete IT

Signed-off-by: Chen Dai <daichen@amazon.com>

* Update doc

Signed-off-by: Chen Dai <daichen@amazon.com>

* Undo import star statements

Signed-off-by: Chen Dai <daichen@amazon.com>

---------

Signed-off-by: Chen Dai <daichen@amazon.com>

Author: dai-chen

DEVELOPER_GUIDE.rst

@@ -294,7 +294,6 @@ For test cases, you can use the cases in the following checklist in case you mis
 
 - *Other Statements*
 
-  - DELETE
   - SHOW
   - DESCRIBE
 

common/src/main/java/org/opensearch/sql/common/setting/Settings.java

@@ -22,7 +22,6 @@ public enum Key {
     SQL_ENABLED("plugins.sql.enabled"),
     SQL_SLOWLOG("plugins.sql.slowlog"),
     SQL_CURSOR_KEEP_ALIVE("plugins.sql.cursor.keep_alive"),
-    SQL_DELETE_ENABLED("plugins.sql.delete.enabled"),
     SQL_PAGINATION_API_SEARCH_AFTER("plugins.sql.pagination.api"),
 
     /** PPL Settings. */

docs/user/admin/settings.rst

@@ -260,61 +260,6 @@ Result set::
       "transient": {}
     }
 
-plugins.sql.delete.enabled
-======================
-
-Description
------------
-
-By default, DELETE clause disabled. You can enable DELETE clause by this setting.
-
-1. The default value is false.
-2. This setting is node scope.
-3. This setting can be updated dynamically.
-
-
-Example 1
----------
-
-You can update the setting with a new value like this.
-
-SQL query::
-
-    sh$ curl -sS -H 'Content-Type: application/json' -X PUT localhost:9200/_plugins/_query/settings \
-    ... -d '{"transient":{"plugins.sql.delete.enabled":"false"}}'
-    {
-      "acknowledged": true,
-      "persistent": {},
-      "transient": {
-        "plugins": {
-          "sql": {
-            "delete": {
-              "enabled": "false"
-            }
-          }
-        }
-      }
-    }
-
-Example 2
----------
-
-Query result after the setting updated is like:
-
-SQL query::
-
-    sh$ curl -sS -H 'Content-Type: application/json' -X POST localhost:9200/_plugins/_sql \
-    ... -d '{"query" : "DELETE * FROM accounts"}'
-    {
-      "error": {
-        "reason": "Invalid SQL query",
-        "details": "DELETE clause is disabled by default and will be deprecated. Using the plugins.sql.delete.enabled setting to enable it",
-        "type": "SQLFeatureDisabledException"
-      },
-      "status": 400
-    }
-
-
 plugins.query.executionengine.spark.session.limit
 ==================================================
 

docs/user/dml/delete.rst

@@ -374,8 +374,6 @@ Description
 
 For ``LIKE`` and other full text search topics, please refer to Full Text Search documentation.
 
-Besides SQL query, WHERE clause can also be used in SQL statement such as ``DELETE``. Please refer to Data Manipulation Language documentation for details.
-
 Example 1: Comparison Operators
 -------------------------------
 

docs/user/dql/basics.rst

@@ -43,10 +43,6 @@ OpenSearch SQL enables you to extract insights out of OpenSearch using the famil
 
   - `Window Functions <dql/window.rst>`_
 
-* **Data Manipulation Language**
-
-  - `DELETE Statement <dml/delete.rst>`_
-
 * **Beyond SQL**
 
   - `PartiQL (JSON) Support <beyond/partiql.rst>`_

docs/user/index.rst

@@ -135,24 +135,6 @@ public void searchSanityFilter() throws IOException {
         result.replaceAll("\\s+", ""), equalTo(expectedOutput.replaceAll("\\s+", "")));
   }
 
-  @Test
-  public void deleteSanity() throws IOException {
-
-    String expectedOutputFilePath =
-        TestUtils.getResourceFilePath("src/test/resources/expectedOutput/delete_explain.json");
-    String expectedOutput =
-        Files.toString(new File(expectedOutputFilePath), StandardCharsets.UTF_8)
-            .replaceAll("\r", "");
-    ;
-
-    String result =
-        explainQuery(
-            String.format(
-                "DELETE FROM %s WHERE firstname LIKE 'A%%' AND age > 20", TEST_INDEX_ACCOUNT));
-    Assert.assertThat(
-        result.replaceAll("\\s+", ""), equalTo(expectedOutput.replaceAll("\\s+", "")));
-  }
-
   @Test
   public void spatialFilterExplainTest() throws IOException {
 

integ-test/src/test/java/org/opensearch/sql/legacy/DeleteIT.java

@@ -17,8 +17,6 @@
 import org.opensearch.client.RequestOptions;
 import org.opensearch.client.Response;
 import org.opensearch.client.ResponseException;
-import org.opensearch.sql.common.setting.Settings;
-import org.opensearch.sql.legacy.utils.StringUtils;
 import org.opensearch.sql.plugin.rest.RestQuerySettingsAction;
 
 public class PluginIT extends SQLIntegTestCase {
@@ -59,31 +57,6 @@ public void sqlEnableSettingsTest() throws IOException {
     wipeAllClusterSettings();
   }
 
-  @Test
-  public void sqlDeleteSettingsTest() throws IOException {
-    updateClusterSettings(
-        new ClusterSetting(PERSISTENT, Settings.Key.SQL_DELETE_ENABLED.getKeyValue(), "false"));
-
-    String deleteQuery = StringUtils.format("DELETE FROM %s", TestsConstants.TEST_INDEX_ACCOUNT);
-    final ResponseException exception =
-        expectThrows(ResponseException.class, () -> executeQuery(deleteQuery));
-    JSONObject actual = new JSONObject(TestUtils.getResponseBody(exception.getResponse()));
-    JSONObject expected =
-        new JSONObject(
-            "{\n"
-                + "  \"error\": {\n"
-                + "    \"reason\": \"Invalid SQL query\",\n"
-                + "    \"details\": \"DELETE clause is disabled by default and will be deprecated."
-                + " Using the plugins.sql.delete.enabled setting to enable it\",\n"
-                + "    \"type\": \"SQLFeatureDisabledException\"\n"
-                + "  },\n"
-                + "  \"status\": 400\n"
-                + "}");
-    assertTrue(actual.toString(), actual.similar(expected));
-
-    wipeAllClusterSettings();
-  }
-
   @Test
   public void sqlTransientOnlySettingTest() throws IOException {
     // (1) compact form