Do not delete disconnected cluster/infraenv. (#3368)

Filter out disconnected clusters from list view

Author: rawagner

libs/types/assisted-installer-service.d.ts

@@ -113,7 +113,7 @@ export interface Cluster {
    * 'AddHostsCluster' for cluster that add hosts to existing OCP cluster,
    *
    */
-  kind: 'Cluster' | 'AddHostsCluster';
+  kind: 'Cluster' | 'AddHostsCluster' | 'DisconnectedCluster';
   /**
    * (DEPRECATED) Please use 'controlPlaneCount' instead. Guaranteed availability of the installed cluster. 'Full' installs a Highly-Available cluster
    * over multiple master nodes whereas 'None' installs a full cluster over one node.

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx

@@ -141,7 +141,7 @@ const OptionalConfigurationsStep = () => {
 
   const { moveNext, moveBack, setDisconnectedInfraEnv, disconnectedInfraEnv } =
     useClusterWizardContext();
-  const { addAlert } = useAlerts();
+  const { addAlert, clearAlerts } = useAlerts();
   // If no pull secret is available, default the checkbox to checked so the field is expanded
   const [editPullSecret, setEditPullSecret] = React.useState(!pullSecret);
 
@@ -185,6 +185,7 @@ const OptionalConfigurationsStep = () => {
       validateOnMount
       validate={validate}
       onSubmit={async (values) => {
+        clearAlerts();
         if (!cluster?.id) {
           addAlert({
             title: t('ai:Missing cluster'),

libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx

@@ -28,15 +28,10 @@ import { Formik } from 'formik';
 import { useNavigate, useParams } from 'react-router-dom-v5-compat';
 
 import { getOperatorSpecs } from '../../../../common/components/operators/operatorSpecs';
-import ClustersService from '../../../services/ClustersService';
-import { handleApiError, getApiErrorMessage } from '../../../../common/api';
-import { useAlerts } from '../../../../common/components/AlertsContextProvider';
-import { AlertVariant } from '@patternfly/react-core';
 
 const ReviewStep = () => {
-  const { moveBack, disconnectedInfraEnv, setDisconnectedInfraEnv } = useClusterWizardContext();
+  const { moveBack, disconnectedInfraEnv } = useClusterWizardContext();
   const { clusterId } = useParams<{ clusterId: string }>();
-  const { addAlert } = useAlerts();
   const opSpecs = getOperatorSpecs(() => undefined);
   const navigate = useNavigate();
 
@@ -52,55 +47,10 @@ const ReviewStep = () => {
         footer={
           <ClusterWizardFooter
             onNext={() => {
-              void (async () => {
-                if (disconnectedInfraEnv?.downloadUrl) {
-                  // Open download in new tab - we need the window reference to detect when download starts
-                  const downloadWindow = window.open(disconnectedInfraEnv.downloadUrl, '_blank');
-
-                  // Wait for the download tab to close (indicates download has started)
-                  // The tab closes automatically when browser initiates the file download
-                  if (downloadWindow) {
-                    await new Promise<void>((resolve) => {
-                      const checkClosed = setInterval(() => {
-                        if (downloadWindow.closed) {
-                          clearInterval(checkClosed);
-                          resolve();
-                        }
-                      }, 200);
-                      // Fallback timeout in case the window doesn't close (e.g., popup blocker)
-                      setTimeout(() => {
-                        clearInterval(checkClosed);
-                        resolve();
-                      }, 10000);
-                    });
-                  }
-                }
-                if (clusterId) {
-                  try {
-                    await ClustersService.remove(clusterId);
-                    // Remove infraEnv from wizard context after successful deregistration
-                    setDisconnectedInfraEnv(undefined);
-                    // Navigate to cluster-list only after successful deregistration
-                    navigate('/cluster-list');
-                  } catch (error) {
-                    handleApiError(error, () => {
-                      addAlert({
-                        title: 'Failed to deregister cluster',
-                        message: getApiErrorMessage(error),
-                        variant: AlertVariant.danger,
-                      });
-                    });
-                    // Error handling: continue with navigation even if deregistration fails
-                    // Still clear the context to avoid stale data
-                    setDisconnectedInfraEnv(undefined);
-                    // Navigate even on error to avoid getting stuck
-                    navigate('/cluster-list');
-                  }
-                } else {
-                  // If there's no cluster to deregister, navigate immediately
-                  navigate('/cluster-list');
-                }
-              })();
+              if (disconnectedInfraEnv?.downloadUrl) {
+                window.open(disconnectedInfraEnv.downloadUrl, '_blank');
+              }
+              navigate('/cluster-list');
             }}
             onBack={moveBack}
             nextButtonText="Download ISO"

libs/ui-lib/lib/ocm/store/slices/clusters/selectors.tsx

@@ -17,7 +17,8 @@ import ClusterStatus, { getClusterStatusText } from '../../../components/cluster
 import { RootStateDay1 } from '../../store-day1';
 import type { Cluster } from '@openshift-assisted/types/assisted-installer-service';
 
-const selectClusters = (state: RootStateDay1) => state.clusters.data;
+const selectClusters = (state: RootStateDay1) =>
+  state.clusters.data.filter((c) => c.kind !== 'DisconnectedCluster');
 const clustersUIState = (state: RootStateDay1) => state.clusters.uiState;
 
 export const selectClustersUIState = createSelector(