[release-v1.16] Tekton 1.0.x fixes (#1349)

* fix: affinity/coschedule tekton issues

Workspace set must be identical for all the tasks.
Having strict subset of workspaces clearly does not work.

Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>

* fix: quote a strings in yaml

Tekton 1.0.x is less permissive.
When the parameter is empty string it must be between quotation mark.

Signed-off-by: Matej Vašek <[email protected]>

---------

Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>

Author: matejvasek

pkg/pipelines/tekton/tasks.go

@@ -406,6 +406,12 @@ spec:
   workspaces:
     - name: source
       description: The workspace containing the function project
+    - name: cache
+      optional: true
+    - name: sslcertdir
+      optional: true
+    - name: dockerconfig
+      optional: true
   steps:
     - name: func-deploy
       image: "%s"
@@ -431,6 +437,15 @@ spec:
     - name: path
       description: Path to the function project
       default: ""
+  workspaces:
+    - name: source
+      description: The workspace containing the function project
+    - name: cache
+      optional: true
+    - name: sslcertdir
+      optional: true
+    - name: dockerconfig
+      optional: true
   steps:
     - name: func-scaffold
       image: %s

pkg/pipelines/tekton/templates_pack.go

@@ -49,6 +49,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
       {{.RunAfterFetchSources}}
       {{.FuncScaffoldTaskRef}}
     - name: build
@@ -86,6 +90,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
   workspaces:
     - description: Directory where function source is located.
       name: source-workspace
@@ -115,11 +123,11 @@ metadata:
 spec:
   params:
     - name: gitRepository
-      value: {{.RepoUrl}}
+      value: "{{.RepoUrl}}"
     - name: gitRevision
       value: {{.Revision}}
     - name: contextDir
-      value: {{.ContextDir}}
+      value: "{{.ContextDir}}"
     - name: imageName
       value: {{.FunctionImage}}
     - name: registry
@@ -182,7 +190,7 @@ spec:
     - name: gitRevision
       value: {{.Revision}}
     - name: contextDir
-      value: {{.ContextDir}}
+      value: "{{.ContextDir}}"
     - name: imageName
       value: {{.FunctionImage}}
     - name: registry

pkg/pipelines/tekton/templates_s2i.go

@@ -53,6 +53,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
       {{.RunAfterFetchSources}}
       {{.FuncScaffoldTaskRef}}
     - name: build
@@ -92,6 +96,10 @@ spec:
       workspaces:
         - name: source
           workspace: source-workspace
+        - name: cache
+          workspace: cache-workspace
+        - name: dockerconfig
+          workspace: dockerconfig-workspace
   workspaces:
     - description: Directory where function source is located.
       name: source-workspace
@@ -120,11 +128,11 @@ metadata:
 spec:
   params:
     - name: gitRepository
-      value: {{.RepoUrl}}
+      value: "{{.RepoUrl}}"
     - name: gitRevision
       value: {{.Revision}}
     - name: contextDir
-      value: {{.ContextDir}}
+      value: "{{.ContextDir}}"
     - name: imageName
       value: {{.FunctionImage}}
     - name: registry
@@ -192,7 +200,7 @@ spec:
     - name: gitRevision
       value: {{.Revision}}
     - name: contextDir
-      value: {{.ContextDir}}
+      value: "{{.ContextDir}}"
     - name: imageName
       value: {{.FunctionImage}}
     - name: registry