Skip to content

Commit 55df89a

Browse files
authored
unify flags, codecov revamp a bit (knative#2773)
Signed-off-by: David Fridrich <[email protected]>
1 parent ff63772 commit 55df89a

File tree

8 files changed

+11
-73
lines changed

8 files changed

+11
-73
lines changed

.codecov.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@ comment:
1616
behavior: default
1717
ignore:
1818
- "testdata"
19-
- "**/zz_*generated*.go"
19+
- "**/zz*_generated.go"
2020
- "templates"
2121
- "hack"
2222
- "test"
23+
- "generate"
24+
- "docs"
25+
- "plugin"
26+
- "schema"
2327
- "third_party"
24-

.github/workflows/ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- uses: codecov/codecov-action@v5
4242
with:
4343
files: ./coverage.txt
44-
flags: unit-tests-${{ matrix.os }}
44+
flags: unit-tests
4545
fail_ci_if_error: true
4646
verbose: true
4747
token: ${{ secrets.CODECOV_TOKEN }}
@@ -130,7 +130,7 @@ jobs:
130130
- uses: codecov/codecov-action@v5
131131
with:
132132
files: ./coverage.txt
133-
flags: e2e-test
133+
flags: e2e-tests
134134
fail_ci_if_error: true
135135
verbose: true
136136
token: ${{ secrets.CODECOV_TOKEN }}
@@ -182,7 +182,7 @@ jobs:
182182
- uses: codecov/codecov-action@v5
183183
with:
184184
files: ./coverage.txt
185-
flags: e2e-test-oncluster
185+
flags: e2e-tests
186186
fail_ci_if_error: true
187187
verbose: true
188188
token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/test-e2e-oncluster-runtime.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,3 @@ jobs:
6464
echo "::group::cluster containers logs"
6565
stern '.*' --all-namespaces --no-follow
6666
echo "::endgroup::"
67-
- uses: codecov/codecov-action@v5
68-
with:
69-
files: ./coverage.txt
70-
flags: e2e-test-oncluster-runtime

.github/workflows/test-e2e-oncluster.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ jobs:
5454
- uses: codecov/codecov-action@v5
5555
with:
5656
files: ./coverage.txt
57-
flags: e2e-test-oncluster
57+
flags: e2e-tests

.github/workflows/test-e2e-runtime.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,3 @@ jobs:
7676
fi
7777
done
7878
echo "------------------ finished! attempt $attempt ------------------"
79-
- uses: codecov/codecov-action@v5
80-
with:
81-
files: ./coverage.txt
82-
flags: e2e-test-runtime-${{ matrix.runtime }}

.github/workflows/test-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ jobs:
4444
- uses: codecov/codecov-action@v5
4545
with:
4646
files: ./coverage.txt
47-
flags: e2e-test
47+
flags: e2e-tests

.github/workflows/test-unit.yaml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,24 +44,7 @@ jobs:
4444
- name: Template Unit Tests
4545
if: matrix.os != 'ubuntu-latest'
4646
run: make test-templates
47-
- name: "Archive code coverage results"
48-
uses: actions/upload-artifact@v4
49-
with:
50-
name: coverage-${{ matrix.os }}
51-
path: ./coverage.txt
52-
retention-days: 1
53-
upload-coverage:
54-
needs: [test]
55-
name: "Upload coverage"
56-
runs-on: "ubuntu-latest"
57-
steps:
58-
- uses: actions/checkout@v4
59-
- name: Download Coverage
60-
run: |
61-
gh run download -R ${{ github.repository }} ${{ github.run_id }}
62-
env:
63-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6447
- uses: codecov/codecov-action@v5
6548
with:
66-
files: ./coverage-ubuntu-latest/coverage.txt,./coverage-windows-latest/coverage.txt,./coverage-macos-latest/coverage.txt
49+
files: ./coverage.txt
6750
flags: unit-tests

pkg/docker/appease_coverage_gods_test.go

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)