Skip to content

Commit 277bc44

Browse files
authored
follow up on moving the on-cluster-builds to a separate namespace (#3820)
1 parent 083f319 commit 277bc44

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ install-all: install-tools
2323
SCALE_UP=4 INSTALL_KAFKA="true" ENABLE_TRACING=true ./hack/install.sh
2424

2525
install-release-next: install-tools generated-files-release-next
26-
ON_CLUSTER_BUILDS=true TARGET_ARCH=$(TARGET_ARCH) TARGET_OS=$(TARGET_OS) ./hack/images.sh image-registry.openshift-image-registry.svc:5000/openshift-marketplace
27-
USE_RELEASE_NEXT=true DOCKER_REPO_OVERRIDE=image-registry.openshift-image-registry.svc:5000/openshift-marketplace ./hack/install.sh
26+
ON_CLUSTER_BUILDS=true TARGET_ARCH=$(TARGET_ARCH) TARGET_OS=$(TARGET_OS) ./hack/images.sh image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds
27+
USE_RELEASE_NEXT=true DOCKER_REPO_OVERRIDE=image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds ./hack/install.sh
2828

2929
install-tracing:
3030
./hack/tracing.sh

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ pushed to your docker repository.
6363
`make images` requires docker or podman to build images, by setting
6464
`ON_CLUSTER_BUILDS=true` env variable, `make images` will build images
6565
using OpenShift Build and they will be available at the in-cluster
66-
registry `image-registry.openshift-image-registry.svc:5000/openshift-marketplace/<image_name>`.
66+
registry `image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds/<image_name>`.
6767

6868
To install the system using those images, use
69-
`DOCKER_REPO_OVERRIDE=image-registry.openshift-image-registry.svc:5000/openshift-marketplace`
69+
`DOCKER_REPO_OVERRIDE=image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds`
7070

7171
### Installing the system
7272

@@ -227,7 +227,7 @@ changed usually are `project.version`, `olm.replaces` and `olm.skipRange`.
227227
Next, add the now outdated version of serverless-operator to the CatalogSource deployment
228228
in [catalogsource.bash](./hack/lib/catalogsource.bash). The image to be added usually has
229229
the following format: `registry.ci.openshift.org/openshift/openshift-serverless-$OLD_VERSION:serverless-bundle`.
230-
Add it before the "current" image, which is `image-registry.openshift-image-registry.svc:5000/$OLM_NAMESPACE/serverless-bundle`.
230+
Add it before the "current" image, which is `image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds/serverless-bundle`.
231231

232232
After the changes are done, commit them and run `make generated-files`. All manifests
233233
will now be updated accordingly. It's encouraged to commit the generated changes

docs/gitops/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ metadata:
3030
argocd.argoproj.io/sync-wave: "2"
3131
spec:
3232
displayName: Serverless Operator
33-
image: image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-index:latest
33+
image: image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds/serverless-index:latest
3434
publisher: Red Hat
3535
sourceType: grpc
3636
---

hack/images.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ echo "On cluster builds: ${on_cluster_builds}"
2626
echo "Target platform: ${TARGET_OS}/${TARGET_ARCH}"
2727

2828
if [[ $on_cluster_builds = true ]]; then
29+
ensure_namespace "${ON_CLUSTER_BUILDS_NAMESPACE}"
2930
# image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds/openshift-knative-operator:latest
3031
build_image "serverless-openshift-knative-operator" "${root_dir}" "openshift-knative-operator/Dockerfile" || exit 1
3132
# image-registry.openshift-image-registry.svc:5000/openshift-serverless-builds/knative-operator:latest

0 commit comments

Comments
 (0)