-
Notifications
You must be signed in to change notification settings - Fork 71
[release1.35] update to 1.35.2 #3757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release1.35] update to 1.35.2 #3757
Conversation
The catalogs are wrong, they're missing 1.35.1 for some reason. |
/hold |
f1ec878
to
369925f
Compare
we need to push at least one 1.35.2 build to CI before we build the catalog with 1.32.2 in it, so dropping the catalog changes for now |
/unhold |
/hold |
/retest-required |
/test 419-operator-e2e |
/test 419-images |
1 similar comment
/test 419-images |
/retest-required |
/retest |
/test 419-test-upgrade |
/retest-required |
/test 419-kitchensink-upgrade |
/test 419-operator-e2e |
/test 419-upstream-e2e |
/test 419-operator-e2e |
/test 419-upstream-e2e-kafka |
@maschmid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaustubh-pande, maschmid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
1f3f1f1
into
openshift-knative:release-1.35
Also,
replaces
andskipRange
versionsAFAIU, the correct versions for replaces and skipRange are,
for a patch release
for a .0 release
(the previous version of the script didn't properly generate the replaces and skipRanges for z>1)
For older releases, we don't want to release into the "stable" channel, just to the "stable-x.y" channel, but the operator "default channel" (the
operators.operatorframework.io.bundle.channel.default.v1
annotation) needs to be kept "stable".(this patch introduces a new
olm.channels.operator_default
to make this be set separately, so the "default" channel to use for testing can be set to the "stable-x.y", while keeping the bundle annotation stay "stable".)We don't have a mechanism in CI nor in Konflux to store working bundles for previous patch releases. The only way we can properly build an index with .0,.1,.2,... bundles is to use actually released bundles from registry.redhat.io.
This patch changes how the olm-catalog/serverless-operator-index/Dockerfile is generated. Instead of adding the "old" CI bundles in build-time via "opm redner" as before, we do run "opm render" in "make generate-catalog", ( which is the only time we have credentials to pull images from registry.redhat.io )
This patch also fixes the "previous" operator versions for patch releases greater than .1 (e.g. for "1.35.3", the previous bundles would be "1.35.2", "1.35.1", "1.35.0", "1.34.0", "1.33.0", ... )
Probably for the above reasons of not actually properly generating previous versions, the upgrade tests used a hack to use redhat-operators if the actual bundle was not in the test catalog. This is now fixed.
This patch also fixes the expected upgrade patch. Given the skipRanges, the path from 1.35.0 goes directly to 1.35.2 , so this patch skips the >1.35.0 <1.35.x versions in the kitchensink-upgrade csvs.