Skip to content

Commit 142534b

Browse files
Merge pull request #836 from shajmakh/fixSkipMsg
Latency e2e: fix skipping report when cpus amount is less than minimum
2 parents 751416e + 4ea50dd commit 142534b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

functests/4_latency/latency.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ var _ = Describe("[performance] Latency Test", func() {
146146
Skip(fmt.Sprintf("Skip the oslat test, the profile %q has less than %d isolated CPUs", profile.Name, minCpuAmountForOslat))
147147
}
148148
if latencyTestCpus < minCpuAmountForOslat && latencyTestCpus != defaultTestCpus {
149-
Skip("Skip the oslat test, LATENCY_TEST_CPUS is less than the minimum CPUs amount %d", minCpuAmountForOslat)
149+
Skip(fmt.Sprintf("Skip the oslat test, LATENCY_TEST_CPUS is less than the minimum CPUs amount %d", minCpuAmountForOslat))
150150
}
151151
})
152152

functests/5_latency_testing/latency_testing.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ const (
3535
incorrectMsgPart2 = " has incorrect value"
3636
invalidNumber = " has an invalid number"
3737
maxInt = "2147483647"
38+
minimumCpuForOslat = "2"
3839
mustBePositiveInt = ".*it must be a positive integer with maximum value of " + maxInt
3940
mustBeNonNegativeInt = ".*it must be a non-negative integer with maximum value of " + maxInt
4041
incorrectCpuNumber = incorrectMsgPart1 + latencyTestCpus + incorrectMsgPart2 + mustBePositiveInt
@@ -62,7 +63,7 @@ const (
6263
//skip messages regex
6364
skipTestRun = `Skip the latency test, the LATENCY_TEST_RUN set to false`
6465
skipMaxLatency = `no maximum latency value provided, skip buckets latency check`
65-
skipOslatCpuNumber = `Skip the oslat test, LATENCY_TEST_CPUS is less than the minimum CPUs amount`
66+
skipOslatCpuNumber = `Skip the oslat test, LATENCY_TEST_CPUS is less than the minimum CPUs amount ` + minimumCpuForOslat
6667
skip = `SUCCESS.*0 Passed.*0 Failed.*3 Skipped`
6768
skipInsufficientCpu = `Insufficient cpu to run the test`
6869

0 commit comments

Comments
 (0)