Skip to content

Commit ee2f3d3

Browse files
Merge pull request #840 from cynepco3hahue/improve_logging
controller: do not truncate original errors
2 parents 3cacbed + 6696047 commit ee2f3d3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

controllers/performanceprofile_controller.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,13 @@ func (r *PerformanceProfileReconciler) mcpToPerformanceProfile(mcpObj client.Obj
147147
Name: mcpObj.GetName(),
148148
}
149149
if err := r.Get(context.TODO(), key, mcp); err != nil {
150-
klog.Errorf("failed to get the machine config pool %+v", key)
150+
klog.Errorf("failed to get the machine config pool %+v: %v", key, err)
151151
return nil
152152
}
153153

154154
profiles := &performancev2.PerformanceProfileList{}
155155
if err := r.List(context.TODO(), profiles); err != nil {
156-
klog.Error("failed to get performance profiles")
156+
klog.Errorf("failed to get performance profiles: %v", err)
157157
return nil
158158
}
159159

@@ -162,7 +162,7 @@ func (r *PerformanceProfileReconciler) mcpToPerformanceProfile(mcpObj client.Obj
162162
profileNodeSelector := labels.Set(profile.Spec.NodeSelector)
163163
mcpNodeSelector, err := metav1.LabelSelectorAsSelector(mcp.Spec.NodeSelector)
164164
if err != nil {
165-
klog.Errorf("failed to parse the selector %v", mcp.Spec.NodeSelector)
165+
klog.Errorf("failed to parse the selector %v: %v", mcp.Spec.NodeSelector, err)
166166
return nil
167167
}
168168

@@ -182,13 +182,13 @@ func (r *PerformanceProfileReconciler) tunedProfileToPerformanceProfile(tunedPro
182182
}
183183

184184
if err := r.Get(context.TODO(), key, node); err != nil {
185-
klog.Errorf("failed to get the tuned profile %+v", key)
185+
klog.Errorf("failed to get the tuned profile %+v: %v", key, err)
186186
return nil
187187
}
188188

189189
profiles := &performancev2.PerformanceProfileList{}
190190
if err := r.List(context.TODO(), profiles); err != nil {
191-
klog.Error("failed to get performance profiles")
191+
klog.Errorf("failed to get performance profiles: %v", err)
192192
return nil
193193
}
194194

0 commit comments

Comments
 (0)