Skip to content

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Dec 19, 2025

Add support for using pre-mirrored images and custom registry certificates when building OVE ISOs, enabling disconnected deployments with custom registries.

Changes for mirror-path:

  • Pass --mirror-path to build-ove-image.sh when MIRROR_IMAGES is enabled
  • Appliance skips oc-mirror and uses pre-mirrored images when --mirror-path is provided

Changes for registry-cert:

  • Add --registry-cert parameter for custom registry TLS certificates
  • Support both script build method (faster for development/debugging) and container build method
  • Use unified mechanism across both build methods
  • Convert to REGISTRY_CERT make variable for containerized builds

Assisted-by: Claude Sonnet 4.5 [email protected]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@openshift-ci openshift-ci bot requested review from celebdor and zaneb December 19, 2025 23:42
Add support for using pre-mirrored images and custom registry
certificates when building OVE ISOs, enabling disconnected
deployments with custom registries.

Changes for mirror-path:
- Pass --mirror-path to build-ove-image.sh when MIRROR_IMAGES is enabled
- Appliance skips oc-mirror and uses pre-mirrored images when --mirror-path is provided

Changes for registry-cert:
- Add --registry-cert parameter for custom registry TLS certificates
- Support both script build method (faster for development/debugging) and container build method
- Use unified mechanism across both build methods
- Convert to REGISTRY_CERT make variable for containerized builds

Assisted-by: Claude Sonnet 4.5 <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rwsu rwsu changed the title WIP: Add support for passing pre-mirrored images to appliance AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@rwsu
Copy link
Contributor Author

rwsu commented Jan 13, 2026

/cc @andfasano @bfournie @pawanpinjarkar
/uncc @celebdor

@openshift-ci openshift-ci bot requested review from andfasano, bfournie and pawanpinjarkar and removed request for celebdor January 13, 2026 23:03
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 27eaaa3 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 27eaaa3 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant