Skip to content

Commit e7146b7

Browse files
hchenxaclaude
andcommitted
fix: add timeouts for git clone and make commands in setup-maestro-cluster
- Add 300s timeout for git clone to prevent indefinite hangs - Add 3600s timeout for make personal-dev-env deployment - Update error messages to indicate timeout conditions Addresses CodeRabbitAI feedback on PR #458 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: hchenxa <huichen@redhat.com>
1 parent 0c832d5 commit e7146b7

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.claude/skills/setup-maestro-cluster/scripts/setup.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ fi
4242

4343
echo "Cloning ARO-HCP repository to: $TEMP_DIR"
4444

45-
if ! git clone https://github.com/Azure/ARO-HCP "$TEMP_DIR/ARO-HCP"; then
46-
echo "ERROR: Failed to clone ARO-HCP repository"
45+
if ! timeout 300 git clone https://github.com/Azure/ARO-HCP "$TEMP_DIR/ARO-HCP"; then
46+
echo "ERROR: Failed to clone ARO-HCP repository (timeout: 300s)"
4747
rm -rf "$TEMP_DIR"
4848
exit 1
4949
fi
@@ -71,13 +71,13 @@ echo "Starting personal-dev-env deployment..."
7171
echo "This may take several minutes..."
7272
echo ""
7373

74-
if make personal-dev-env; then
74+
if timeout 3600 make personal-dev-env; then
7575
echo ""
7676
echo "✓ Deployment completed successfully!"
7777
echo "ARO-HCP repository location: $TEMP_DIR/ARO-HCP"
7878
else
7979
echo ""
80-
echo "ERROR: Deployment failed!"
80+
echo "ERROR: Deployment failed or timed out (timeout: 3600s)!"
8181
popd > /dev/null
8282
exit 1
8383
fi

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,7 @@ test/e2e/setup/aro/aro-hcp
7171
test/upgrade/report/*
7272

7373
# Ignore ARO-HCP kubeconfig
74-
*.kubeconfig
74+
*.kubeconfig
75+
76+
# Ignore diagnostic reports
77+
maestro-diagnosis-*.txt

0 commit comments

Comments
 (0)