Skip to content

SRVKP-9397: updated field name for capturing next page token in tkr #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SRVKP-9397: updated field name for capturing next page token in tkr #815

wants to merge 1 commit into from
+4 −1

Conversation

@anwesha-palit-redhat
Copy link
Contributor

@anwesha-palit-redhat anwesha-palit-redhat commented Nov 26, 2025

PR Description

This PR fixes an issue where scrolling fails to load additional PipelineRun results when the data_source filter is set to archived. The onScroll callback never triggered the next-page request because the Tekton Results client was reading nextPageToken, while the API returns next_page_token. Due to this mismatch, the next-page callback was not created, causing pagination to stop after the first page.

For demonstration purposes, the page_size has been temporarily set to 10 to make pagination behavior easier to observe.

Steps to Reproduce

  1. Open the PipelineRun list page.
  2. Set the data_source filter to archived.
  3. Scroll to the bottom.
  4. No additional results load.

Actual Result

Pagination stops after the first page; scrolling does not fetch more results.

Expected Result

The list should fetch the next page using next_page_token and load results continuously as the user scrolls.

Root Cause

The client expected nextPageToken, but the API provides next_page_token, preventing the next-page fetch logic from initializing.

Fix Implemented

  • Updated pagination logic to use next_page_token from the API response.

Screen Recording Before

issue_9397.mov

Screen Recording After

https://drive.google.com/file/d/1nAAVR7Uu3UaC7ljFKBnJUxqZafCn6YaN/view?usp=sharing

@anwesha-palit-redhat anwesha-palit-redhat changed the title fix: updated field name for capturing next page token in tkr SRVKP-9397: updated field name for capturing next page token in tkr Nov 26, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 26, 2025 •
edited by openshift-ci bot
Loading

@anwesha-palit-redhat: This pull request references SRVKP-9397 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

PR Description

This PR fixes an issue where scrolling fails to load additional PipelineRun results when the data_source filter is set to archived. The onScroll callback never triggered the next-page request because the Tekton Results client was reading nextPageToken, while the API returns next_page_token. Due to this mismatch, the next-page callback was not created, causing pagination to stop after the first page.

For demonstration purposes, the page_size has been temporarily set to 10 to make pagination behavior easier to observe.

Steps to Reproduce

  1. Open the PipelineRun list page.
  2. Set the data_source filter to archived.
  3. Scroll to the bottom.
  4. No additional results load.

Actual Result

Pagination stops after the first page; scrolling does not fetch more results.

Expected Result

The list should fetch the next page using next_page_token and load results continuously as the user scrolls.

Root Cause

The client expected nextPageToken, but the API provides next_page_token, preventing the next-page fetch logic from initializing.

Fix Implemented

  • Updated pagination logic to use next_page_token from the API response.

Screen Recording Before

issue_9397.mov

Screen Recording After

https://drive.google.com/file/d/1nAAVR7Uu3UaC7ljFKBnJUxqZafCn6YaN/view?usp=sharing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj
Copy link
Member

vikram-raj commented Nov 26, 2025

/cc @pratap0007

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@vikram-raj: GitHub didn't allow me to request PR reviews from the following users: pratap0007.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pratap0007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anwesha-palit-redhat
Copy link
Contributor Author

anwesha-palit-redhat commented Nov 26, 2025

/cc @arvindk-softwaredev

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@anwesha-palit-redhat: GitHub didn't allow me to request PR reviews from the following users: arvindk-softwaredev.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @arvindk-softwaredev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arvindk-softwaredev
Copy link

arvindk-softwaredev commented Nov 26, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@arvindk-softwaredev: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pratap0007
Copy link
Contributor

pratap0007 commented Nov 27, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@pratap0007: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@arvindk-softwaredev
Copy link

arvindk-softwaredev commented Nov 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester Awaiting requested review from vdemeester

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@arvindk-softwaredev arvindk-softwaredev Awaiting requested review from arvindk-softwaredev

@pratap0007 pratap0007 Awaiting requested review from pratap0007

Assignees

@arvindk-softwaredev arvindk-softwaredev

Labels

jira/valid-reference lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anwesha-palit-redhat @openshift-ci-robot @vikram-raj @arvindk-softwaredev @pratap0007