feat(approvaltask): add approval progress tracking fields

Introduces approvalsRequired and approvalsReceived status fields
to track approval progress, supporting both users and groups.

Signed-off-by: PuneetPunamiya <[email protected]>

Author: PuneetPunamiya

pkg/apis/approvaltask/v1alpha1/approvaltask_types.go

@@ -66,6 +66,10 @@ type ApprovalTaskStatus struct {
 	ApproversResponse []ApproverState `json:"approversResponse,omitempty"`
 	// StartTime is the time the build is actually started.
 	StartTime *metav1.Time `json:"startTime,omitempty"`
+	// ApprovalsRequired is the number of approvals required for the task
+	ApprovalsRequired int `json:"approvalsRequired,omitempty"`
+	// ApprovalsReceived is the number of approvals received so far
+	ApprovalsReceived int `json:"approvalsReceived,omitempty"`
 }
 
 type GroupMemberState struct {

pkg/reconciler/approvaltask/utils.go

@@ -259,6 +259,8 @@ func createApprovalTask(ctx context.Context, approvaltaskClientSet versioned.Int
 		State:             pendingState,
 		Approvers:         users,
 		ApproversResponse: []v1alpha1.ApproverState{},
+		ApprovalsRequired: numberOfApprovalsRequired,
+		ApprovalsReceived: 0, // Initially no approvals received
 	}
 
 	at.Status = status
@@ -304,6 +306,29 @@ func approvalTaskHasTrueInput(approvalTask v1alpha1.ApprovalTask) bool {
 	return len(approvedUsers) >= requiredApprovals
 }
 
+func countApprovalsReceived(approvalTask v1alpha1.ApprovalTask) int {
+	// Count unique users who have approved
+	approvedUsers := make(map[string]bool)
+
+	for _, approver := range approvalTask.Spec.Approvers {
+		if approver.Input != hasApproved {
+			continue
+		}
+
+		if approver.Type == "User" {
+			approvedUsers[approver.Name] = true
+		} else if approver.Type == "Group" {
+			for _, user := range approver.Users {
+				if user.Input == hasApproved {
+					approvedUsers[user.Name] = true
+				}
+			}
+		}
+	}
+
+	return len(approvedUsers)
+}
+
 func (r *Reconciler) checkIfUpdateRequired(ctx context.Context, approvalTask v1alpha1.ApprovalTask, run *v1beta1.CustomRun) error {
 	logger := logging.FromContext(ctx)
 
@@ -414,6 +439,10 @@ func updateApprovalState(ctx context.Context, approvaltaskClientSet versioned.In
 		// Update the ApprovedBy list
 		approvalTask.Status.ApproversResponse = filteredApprovedBy
 
+		// Update the approvals count fields
+		approvalTask.Status.ApprovalsRequired = approvalTask.Spec.NumberOfApprovalsRequired
+		approvalTask.Status.ApprovalsReceived = countApprovalsReceived(*approvalTask)
+
 		// Update the approvalState
 		// Reject scenario: Check if there is one false and if found mark the approvalstate to false
 		// Approve scenario: Check if the input value from the user is true and is equal to the approvalsRequired