Adds support for group of users in Manual Approval

This patch aligns Approval Task spec with some new fields
  - adds `type` field for both `User` and `Group`
  - adds support for approver groups
  - enhanced status tracking with `approverResponse` including group and users

To refer group name in pipelinerun add `group:` keyword

```
params:
  - name: approvers
    value:
      - foo
      - bar
      - group:tekton             # 👉 `group:<groupName>`
      - group:example
```

With this patch now when the approvalTask is created it will look as

```
apiVersion: openshift-pipelines.org/v1alpha1
kind: ApprovalTask
metadata:
  annotations:
    tekton.dev/last-applied-hash: 45f48c89406b77d2c7be34c01fca34587a867e5c1db74d87958e7d5995d2c895
  creationTimestamp: "2025-07-07T11:13:04Z"
  generation: 3
  labels:
    tekton.dev/customRun: pr-custom-task-beta-cgb54-wait
    tekton.dev/memberOf: tasks
    tekton.dev/pipeline: pr-custom-task-beta-cgb54
    tekton.dev/pipelineRun: pr-custom-task-beta-cgb54
    tekton.dev/pipelineRunUID: 8d44f040-1740-404c-b9d9-f77f52d5e5f4
    tekton.dev/pipelineTask: wait
  name: pr-custom-task-beta-cgb54-wait
  namespace: default
  ownerReferences:
  - apiVersion: tekton.dev/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: CustomRun
    name: pr-custom-task-beta-cgb54-wait
    uid: 84debd0b-5b03-4d28-b0f5-474f8e602dac
  resourceVersion: "1856714"
  uid: e014fb1b-e6ea-48e2-af72-7455f300a308
spec:
  approvers:
  - input: pending
    name: foo
    type: User                             # 👉 New field added
  - input: pending
    name: bar
    type: User
  - input: pending
    name: user3
    type: User
  - input: reject
    name: user2
    type: User
  - input: pending
    name: tekton
    type: Group
  - input: reject
    name: example
    type: Group                            # 👉 New field added
    users:				   # 👉 When users from group approve or reject
     - name: user1
       input: approve
     - name: user2
       input: reject
  description: Approval Task Rocks!!!
  numberOfApprovalsRequired: 2
status:
  approvers:
  - foo
  - bar
  - user3
  - user2
  - group:tekton
  - group:example
  approversResponse:
    - response: approved
      name: foo
      type: User                       # New field added
    - response: approved
      name: abc
      type: User                       # New field added
    - response: rejected
      name: tekton-team
      type: Group              # New field added
      groupMembers:
       - name: user1
         response: rejected
  startTime: "2025-07-07T11:13:04Z"
  state: rejected
```

Scenarios handled:

Controller
 - Until and unless approval task does not get approval from the users as true, till that approvalState will be `wait`
 - If any one use disapproves the approval task we will mark the approvalState as false and then the pipelinerun will fail
 - If a user approves for the first time and still approvalsRequired limit is not reached i.e. approvalState is `wait`
   then user can still change his input and mark the approval task as `false`
 - Approvals from both type as `user` and type as `group` is allowed at once

Adds e2e test for support of group of users

Signed-off-by: PuneetPunamiya <[email protected]>

refactor the design

Signed-off-by: PuneetPunamiya <[email protected]>

Author: PuneetPunamiya

pkg/apis/approvaltask/v1alpha1/approvaltask_types.go

@@ -46,10 +46,17 @@ type ApprovalTaskSpec struct {
 	Description               string            `json:"description,omitempty"`
 }
 
+type UserDetails struct {
+	Name  string `json:"name"`
+	Input string `json:"input"`
+}
+
 type ApproverDetails struct {
-	Name    string `json:"name"`
-	Input   string `json:"input"`
-	Message string `json:"message,omitempty"`
+	Name    string        `json:"name"`
+	Input   string        `json:"input"`
+	Message string        `json:"message,omitempty"`
+	Type    string        `json:"type"`
+	Users   []UserDetails `json:"users,omitempty"`
 }
 
 type ApprovalTaskStatus struct {
@@ -61,12 +68,20 @@ type ApprovalTaskStatus struct {
 	StartTime *metav1.Time `json:"startTime,omitempty"`
 }
 
-type ApproverState struct {
+type GroupMemberState struct {
 	Name     string `json:"name"`
 	Response string `json:"response"`
 	Message  string `json:"message,omitempty"`
 }
 
+type ApproverState struct {
+	Name         string             `json:"name"`
+	Response     string             `json:"response"`
+	Message      string             `json:"message,omitempty"`
+	Type         string             `json:"type"`
+	GroupMembers []GroupMemberState `json:"groupMembers,omitempty"`
+}
+
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // ApprovalTaskList contains a list of ApprovalTasks

pkg/apis/approvaltask/v1alpha1/zz_generated.deepcopy.go

@@ -26,10 +26,12 @@ func TestApproveApprovalTask(t *testing.T) {
 					{
 						Name:  "tekton",
 						Input: "pending",
+						Type:  "User",
 					},
 					{
 						Name:  "cli",
 						Input: "pending",
+						Type:  "User",
 					},
 				},
 				NumberOfApprovalsRequired: 2,
@@ -52,10 +54,12 @@ func TestApproveApprovalTask(t *testing.T) {
 					{
 						Name:  "tekton",
 						Input: "pending",
+						Type:  "User",
 					},
 					{
 						Name:  "cli",
 						Input: "pending",
+						Type:  "User",
 					},
 				},
 				NumberOfApprovalsRequired: 2,
@@ -78,10 +82,12 @@ func TestApproveApprovalTask(t *testing.T) {
 					{
 						Name:  "tekton",
 						Input: "pending",
+						Type:  "User",
 					},
 					{
 						Name:  "cli",
 						Input: "pending",
+						Type:  "User",
 					},
 				},
 				NumberOfApprovalsRequired: 2,