Check OLM subscription status

We also need to check the OLM subscription status to verify the install
of Pipeline Service is complete. ArgoCD will sync the OLM Subscription
object, but may not necessarily reflect accurate sync and health data
of the underlying deployments.

Per review, also removing premature exit if an application or
subscription does not meet the install criteria. This allows the
deployment status to be checked/dumped at the end.

Signed-off-by: Adam Kaplan <[email protected]>

Author: adambkaplan

operator/images/cluster-setup/content/bin/install.sh

@@ -130,6 +130,9 @@ install_clusters() {
     printf -- "- Checking application status\n"
     check_applications "openshift-gitops" "pipeline-service" | indent 4
 
+    printf -- "- Checking subscription status\n"
+    check_subscriptions "openshift-operators" "openshift-pipelines-operator" | indent 4
+
     #checking if the pipelines and triggers pods are up and running
     printf -- "- Checking deployment status\n"
     tektonDeployments=("tekton-pipelines-controller" "tekton-triggers-controller" "tekton-triggers-core-interceptors")

operator/images/cluster-setup/content/bin/utils.sh

@@ -32,7 +32,6 @@ check_applications() {
     if ! timeout 300s bash -c "while ! kubectl get application/$app -n $ns >/dev/null 2>/dev/null; do printf '.'; sleep 10; done"; then
       printf "%s not found (timeout)\n" "$app"
       kubectl get application/"$app" -n "$ns"
-      kubectl -n "$ns" get events | grep Warning
       exit 1
     else
       printf "Exists"
@@ -46,12 +45,37 @@ check_applications() {
       else
         printf ", Unhealthy\n"
         kubectl -n "$ns" describe "application/$app"
-        exit 1
       fi
     else
       printf ", OutOfSync\n"
       kubectl -n "$ns" describe "application/$app"
+    fi
+  done
+}
+
+check_subscriptions() {
+  local ns="$1"
+  shift
+  local subscriptions=("$@")
+
+  for sub in "${subscriptions[@]}"; do
+    printf -- "- %s: " "$sub"
+
+    #a loop to check if the OLM Subscription exists
+    if ! timeout 300s bash -c "while ! kubectl get subscription/$sub -n $ns >/dev/null 2>/dev/null; do printf '.'; sleep 10; done"; then
+      printf "%s not found (timeout)\n" "$sub"
+      kubectl get subscription/"$sub" -n "$ns"
       exit 1
+    else
+      printf "Exists"
+    fi
+
+     #a loop to check if the OLM Subscription is at the latest known version
+    if kubectl wait --for=jsonpath="{.status.state}"="AtLatestKnown" "subscription/$sub" -n "$ns" --timeout=600s >/dev/null; then
+      printf ", AtLatestKnown\n"
+    else
+      printf ", NotUpdated\n"
+      kubectl -n "$ns" describe "subscription/$sub"
     fi
   done
 }