fix: auto-detect hub type when catalog type is empty

When the catalog type is not specified, the code now probes the
Artifact Hub stats endpoint to determine the catalog type. If the
endpoint responds successfully, the catalog is treated as Artifact Hub;
otherwise, it falls back to Tekton Hub.

- Call /api/v1/stats endpoint to detect Artifact Hub catalogs
- Fallback to Tekton Hub if the API call fails
- Update tests with HTTP mock client for catalog type detection

https://issues.redhat.com/browse/SRVKP-9248

Signed-off-by: Zaki Shaikh <[email protected]>

Author: zakisk

docs/content/docs/install/settings.md

@@ -211,9 +211,11 @@ Pipelines-as-Code supports fetching tasks and pipelines with its remote annotati
 
   The type of hub catalog. Supported values are:
 
-  * `artifacthub` - For Artifact Hub (default if not specified)
+  * `artifacthub` - For Artifact Hub
   * `tektonhub` - For Tekton Hub
 
+  If `hub-catalog-type` is empty, Pipelines as Code will auto-detect the catalog type by probing the Artifact Hub stats endpoint. If the endpoint responds successfully, the catalog is treated as Artifact Hub; otherwise, it falls back to Tekton Hub.
+
 * By default, both Artifact Hub and Tekton Hub are configured:
 
   * Artifact Hub is the default catalog (no prefix needed, but `artifact://` can be used explicitly)

pkg/params/settings/default.go

@@ -1,9 +1,13 @@
 package settings
 
 import (
+	"context"
 	"fmt"
+	"net/http"
 	"net/url"
+	"strings"
 	"sync"
+	"time"
 
 	hubtypes "github.com/openshift-pipelines/pipelines-as-code/pkg/hub/vars"
 	"go.uber.org/zap"
@@ -20,6 +24,9 @@ func getHubCatalogs(logger *zap.SugaredLogger, catalogs *sync.Map, config map[st
 
 	if hubType, ok := config[HubCatalogTypeKey]; !ok || hubType == "" {
 		config[HubCatalogTypeKey] = hubtypes.ArtifactHubType
+		if config[HubURLKey] != "" {
+			config[HubCatalogTypeKey] = getHubCatalogTypeViaAPI(config[HubURLKey])
+		}
 	} else if hubType != hubtypes.ArtifactHubType && hubType != hubtypes.TektonHubType {
 		logger.Warnf("CONFIG: invalid hub type %s, defaulting to %s", hubType, hubtypes.ArtifactHubType)
 		config[HubCatalogTypeKey] = hubtypes.ArtifactHubType
@@ -105,3 +112,28 @@ func getHubCatalogs(logger *zap.SugaredLogger, catalogs *sync.Map, config map[st
 	}
 	return catalogs
 }
+
+func getHubCatalogTypeViaAPI(hubURL string) string {
+	statsURL := fmt.Sprintf("%s/api/v1/stats", strings.TrimSuffix(hubURL, "/"))
+
+	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+	defer cancel()
+
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, statsURL, nil)
+	if err != nil {
+		return hubtypes.TektonHubType
+	}
+
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return hubtypes.TektonHubType
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode == http.StatusOK {
+		return hubtypes.ArtifactHubType
+	}
+
+	// if the API call fails, return Tekton Hub type
+	return hubtypes.TektonHubType
+}

pkg/params/settings/default_test.go

@@ -1,9 +1,12 @@
 package settings
 
 import (
+	"net/http"
+	"net/http/httptest"
 	"sync"
 	"testing"
 
+	hubtypes "github.com/openshift-pipelines/pipelines-as-code/pkg/hub/vars"
 	"go.uber.org/zap"
 	zapobserver "go.uber.org/zap/zaptest/observer"
 	"gotest.tools/v3/assert"
@@ -163,3 +166,39 @@ func TestGetCatalogHub(t *testing.T) {
 		})
 	}
 }
+
+func TestGetHubCatalogTypeViaAPI(t *testing.T) {
+	tests := []struct {
+		name           string
+		serverStatus   int
+		expectedResult string
+	}{
+		{
+			name:           "returns ArtifactHubType on 200 OK",
+			serverStatus:   http.StatusOK,
+			expectedResult: hubtypes.ArtifactHubType,
+		},
+		{
+			name:           "returns TektonHubType on 404 Not Found",
+			serverStatus:   http.StatusNotFound,
+			expectedResult: hubtypes.TektonHubType,
+		},
+		{
+			name:           "returns TektonHubType on 500 Internal Server Error",
+			serverStatus:   http.StatusInternalServerError,
+			expectedResult: hubtypes.TektonHubType,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+				w.WriteHeader(tt.serverStatus)
+			}))
+			defer server.Close()
+
+			result := getHubCatalogTypeViaAPI(server.URL)
+			assert.Equal(t, result, tt.expectedResult)
+		})
+	}
+}