Do checks if the pipeline run is the latest later

In reconciler when checking if the pipeline run is the latest, we
should check this after pr is done so we do that API call (which is not
cached) the less often as possible.

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/reconciler/reconciler.go

@@ -54,15 +54,6 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, pr *tektonv1.PipelineRun
 		return nil
 	}
 
-	// make sure we have the latest pipelinerun to reconcile, since there is something updating at the same time
-	lpr, err := r.run.Clients.Tekton.TektonV1().PipelineRuns(pr.GetNamespace()).Get(ctx, pr.GetName(), metav1.GetOptions{})
-	if err != nil {
-		return fmt.Errorf("cannot get pipelineRun: %w", err)
-	}
-	if lpr.GetResourceVersion() != pr.GetResourceVersion() {
-		return nil
-	}
-
 	// if its a GitHub App pipelineRun PR then process only if check run id is added otherwise wait
 	if _, ok := pr.Annotations[keys.InstallationID]; ok {
 		if _, ok := pr.Annotations[keys.CheckRunID]; !ok {
@@ -80,6 +71,15 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, pr *tektonv1.PipelineRun
 		return nil
 	}
 
+	// make sure we have the latest pipelinerun to reconcile, since there is something updating at the same time
+	lpr, err := r.run.Clients.Tekton.TektonV1().PipelineRuns(pr.GetNamespace()).Get(ctx, pr.GetName(), metav1.GetOptions{})
+	if err != nil {
+		return fmt.Errorf("cannot get pipelineRun: %w", err)
+	}
+	if lpr.GetResourceVersion() != pr.GetResourceVersion() {
+		return nil
+	}
+
 	logger = logger.With(
 		"pipeline-run", pr.GetName(),
 		"event-sha", pr.GetAnnotations()[keys.SHA],