remove non ending alphanumeric characters from labels

Fixes #1086

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/formatting/k8labels.go

@@ -5,7 +5,12 @@ import "strings"
 // K8LabelsCleanup k8s do not like slash in labels value and on push we have the
 // full ref, we replace the "/" by "-". The tools probably need to be aware of
 // it when querying.
+//
+// valid label must be an empty string or consist of alphanumeric characters,
+// '-', '_' or '.', and must start and end with an alphanumeric character
+// (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is
+// '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
 func K8LabelsCleanup(s string) string {
 	replasoeur := strings.NewReplacer("/", "-", " ", "_", "[", "__", "]", "__")
-	return replasoeur.Replace(s)
+	return replasoeur.Replace(strings.TrimRight(s, " -_[]"))
 }

pkg/formatting/k8labels_test.go

@@ -21,7 +21,12 @@ func TestK8LabelsCleanup(t *testing.T) {
 		{
 			name: "github bot name",
 			str:  "github-actions[bot]",
-			want: "github-actions__bot__",
+			want: "github-actions__bot",
+		},
+		{
+			name: "trailing dash name removed",
+			str:  "MBAPPEvsMESSI--",
+			want: "MBAPPEvsMESSI",
 		},
 	}
 	for _, tt := range tests {